Use Decompose for navigation #165
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @kpgalligan, here is a PR demonstrating the integration of Decompose. That's a lot of code. All ViewModels a replaced with Components. The navigation is entirely handled by Decompose, plus there are some fancy animations. I have tested the Android app with Compose UI, and the iOS app with SwiftUI. I couldn't test the iOS app with Compose for iOS for some technical reasons - Compose for iOS currently crashes at runtime on my specific machine (some hardware issues), but it does compile just fine. I will appreciate if someone verify how it actually works, I guess it should be fine.