Skip to content

Add default to formatted annotation #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

flying-sheep
Copy link
Contributor

@flying-sheep flying-sheep commented Sep 12, 2019

WIP.

Fixes #48

@flying-sheep
Copy link
Contributor Author

I don’t understand how my changes cause this:

>           assert text_contents == expected_contents
E           assert 'Dummy Module...     "None"\n' == 'Dummy Module...     "None"\n'
E             Skipping 3774 identical leading characters in diff, use -v to show
E             -    **x** (Callable[[int, bytes], int] (default: "None")) -- foo
E             +    **x** (*Callable**[**[**int**, **bytes**]**, **int**]* (default: "None")) -- foo
E             ?           +        ++ ++ ++   ++  ++     ++ ++  ++   ++ +
E               
E                     Return type:
E                        ClassWithTypehintsNotInline...
E             
E             ...Full output truncated (20 lines hidden), use '-vv' to show

@gaborbernat
Copy link
Member

This seems very outdated now, I'll close this as such, but we can reopen a new PR if we figure this one out.

@flying-sheep flying-sheep deleted the patch-1 branch January 3, 2022 09:02
@flying-sheep flying-sheep mentioned this pull request Jan 4, 2022
@flying-sheep
Copy link
Contributor Author

I re-did the PR: #191

Would be nice if you could take a look this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Also annotate parameter defaults.
2 participants