Skip to content

Conversation

Futadaruma
Copy link
Contributor

@Futadaruma Futadaruma commented Jul 11, 2025

portal-devのdeployment.yamlから不要部分を削除
ラベル名を生成されたものから変更

#845 と同様の変更です
part of #822

@Futadaruma Futadaruma changed the title refactor portalno refactor portalのlabel 名をdev環境と合わせシンプルに Jul 11, 2025
Copy link

github-actions bot commented Jul 11, 2025

Diff

@@ metadata @@
# v1/Secret/portal/portal-ec-private-f7h6ck2dff
! - one map entry removed:
- labels:
-   io.kompose.service: portal-backend

@@ metadata @@
# v1/Secret/portal/portal-ec-pub-k56t5kt78k
! - one map entry removed:
- labels:
-   io.kompose.service: portal-backend

@@ metadata @@
# v1/Service/portal/portal-backend
! - one map entry removed:
- annotations:
-   kompose.cmd: "kompose convert -f docker-compose.yml"
-   kompose.version: "1.35.0 (9532ceef3)"

@@ metadata.labels @@
# v1/Service/portal/portal-backend
! - one map entry removed:
- io.kompose.service: portal-backend
! + one map entry added:
+   app: portal-backend

@@ spec.selector @@
# v1/Service/portal/portal-backend
! - one map entry removed:
- io.kompose.service: portal-backend
! + one map entry added:
+   app: portal-backend

@@ metadata @@
# v1/Service/portal/portal-frontend
! - one map entry removed:
- annotations:
-   kompose.cmd: "kompose convert -f docker-compose.yml"
-   kompose.version: "1.35.0 (9532ceef3)"

@@ metadata.labels @@
# v1/Service/portal/portal-frontend
! - one map entry removed:
- io.kompose.service: portal-frontend
! + one map entry added:
+   app: portal-frontend

@@ spec.selector @@
# v1/Service/portal/portal-frontend
! - one map entry removed:
- io.kompose.service: portal-frontend
! + one map entry added:
+   app: portal-frontend

@@ metadata @@
# apps/v1/Deployment/portal/portal-backend
! - one map entry removed:
- annotations:
-   kompose.cmd: "kompose convert -f docker-compose.yml"
-   kompose.version: "1.35.0 (9532ceef3)"

@@ metadata.labels @@
# apps/v1/Deployment/portal/portal-backend
! - one map entry removed:
- io.kompose.service: portal-backend
! + one map entry added:
+   app: portal-backend

@@ spec.selector.matchLabels @@
# apps/v1/Deployment/portal/portal-backend
! - one map entry removed:
- io.kompose.service: portal-backend
! + one map entry added:
+   app: portal-backend

@@ spec.template.metadata @@
# apps/v1/Deployment/portal/portal-backend
! - one map entry removed:
- annotations:
-   kompose.cmd: "kompose convert -f docker-compose.yml"
-   kompose.version: "1.35.0 (9532ceef3)"

@@ spec.template.metadata.labels @@
# apps/v1/Deployment/portal/portal-backend
! - one map entry removed:
- io.kompose.service: portal-backend
! + one map entry added:
+   app: portal-backend

@@ metadata @@
# apps/v1/Deployment/portal/portal-frontend
! - one map entry removed:
- annotations:
-   kompose.cmd: "kompose convert -f docker-compose.yml"
-   kompose.version: "1.35.0 (9532ceef3)"

@@ metadata.labels @@
# apps/v1/Deployment/portal/portal-frontend
! - one map entry removed:
- io.kompose.service: portal-frontend
! + one map entry added:
+   app: portal-frontend

@@ spec.selector.matchLabels @@
# apps/v1/Deployment/portal/portal-frontend
! - one map entry removed:
- io.kompose.service: portal-frontend
! + one map entry added:
+   app: portal-frontend

@@ spec.template.metadata @@
# apps/v1/Deployment/portal/portal-frontend
! - one map entry removed:
- annotations:
-   kompose.cmd: "kompose convert -f docker-compose.yml"
-   kompose.version: "1.35.0 (9532ceef3)"

@@ spec.template.metadata.labels @@
# apps/v1/Deployment/portal/portal-frontend
! - one map entry removed:
- io.kompose.service: portal-frontend
! + one map entry added:
+   app: portal-frontend

@Futadaruma Futadaruma requested a review from Kentaro1043 July 11, 2025 08:30
Copy link
Contributor

@Kentaro1043 Kentaro1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

service.yamlkomposeと書いてあるところを、このコミットでやってるみたいに変えて欲しいです!
3781ba1

@Futadaruma Futadaruma requested a review from Kentaro1043 July 12, 2025 09:28
Copy link
Contributor

@Kentaro1043 Kentaro1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ありがとう!!

@Kentaro1043
Copy link
Contributor

作業時にApproveします

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants