-
Notifications
You must be signed in to change notification settings - Fork 4
refactor portalのlabel 名をdev環境と合わせシンプルに #1002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Futadaruma
wants to merge
3
commits into
main
Choose a base branch
from
refactor-portal
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+29
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diff@@ metadata @@
# v1/Secret/portal/portal-ec-private-f7h6ck2dff
! - one map entry removed:
- labels:
- io.kompose.service: portal-backend
@@ metadata @@
# v1/Secret/portal/portal-ec-pub-k56t5kt78k
! - one map entry removed:
- labels:
- io.kompose.service: portal-backend
@@ metadata @@
# v1/Service/portal/portal-backend
! - one map entry removed:
- annotations:
- kompose.cmd: "kompose convert -f docker-compose.yml"
- kompose.version: "1.35.0 (9532ceef3)"
@@ metadata.labels @@
# v1/Service/portal/portal-backend
! - one map entry removed:
- io.kompose.service: portal-backend
! + one map entry added:
+ app: portal-backend
@@ spec.selector @@
# v1/Service/portal/portal-backend
! - one map entry removed:
- io.kompose.service: portal-backend
! + one map entry added:
+ app: portal-backend
@@ metadata @@
# v1/Service/portal/portal-frontend
! - one map entry removed:
- annotations:
- kompose.cmd: "kompose convert -f docker-compose.yml"
- kompose.version: "1.35.0 (9532ceef3)"
@@ metadata.labels @@
# v1/Service/portal/portal-frontend
! - one map entry removed:
- io.kompose.service: portal-frontend
! + one map entry added:
+ app: portal-frontend
@@ spec.selector @@
# v1/Service/portal/portal-frontend
! - one map entry removed:
- io.kompose.service: portal-frontend
! + one map entry added:
+ app: portal-frontend
@@ metadata @@
# apps/v1/Deployment/portal/portal-backend
! - one map entry removed:
- annotations:
- kompose.cmd: "kompose convert -f docker-compose.yml"
- kompose.version: "1.35.0 (9532ceef3)"
@@ metadata.labels @@
# apps/v1/Deployment/portal/portal-backend
! - one map entry removed:
- io.kompose.service: portal-backend
! + one map entry added:
+ app: portal-backend
@@ spec.selector.matchLabels @@
# apps/v1/Deployment/portal/portal-backend
! - one map entry removed:
- io.kompose.service: portal-backend
! + one map entry added:
+ app: portal-backend
@@ spec.template.metadata @@
# apps/v1/Deployment/portal/portal-backend
! - one map entry removed:
- annotations:
- kompose.cmd: "kompose convert -f docker-compose.yml"
- kompose.version: "1.35.0 (9532ceef3)"
@@ spec.template.metadata.labels @@
# apps/v1/Deployment/portal/portal-backend
! - one map entry removed:
- io.kompose.service: portal-backend
! + one map entry added:
+ app: portal-backend
@@ metadata @@
# apps/v1/Deployment/portal/portal-frontend
! - one map entry removed:
- annotations:
- kompose.cmd: "kompose convert -f docker-compose.yml"
- kompose.version: "1.35.0 (9532ceef3)"
@@ metadata.labels @@
# apps/v1/Deployment/portal/portal-frontend
! - one map entry removed:
- io.kompose.service: portal-frontend
! + one map entry added:
+ app: portal-frontend
@@ spec.selector.matchLabels @@
# apps/v1/Deployment/portal/portal-frontend
! - one map entry removed:
- io.kompose.service: portal-frontend
! + one map entry added:
+ app: portal-frontend
@@ spec.template.metadata @@
# apps/v1/Deployment/portal/portal-frontend
! - one map entry removed:
- annotations:
- kompose.cmd: "kompose convert -f docker-compose.yml"
- kompose.version: "1.35.0 (9532ceef3)"
@@ spec.template.metadata.labels @@
# apps/v1/Deployment/portal/portal-frontend
! - one map entry removed:
- io.kompose.service: portal-frontend
! + one map entry added:
+ app: portal-frontend
|
Kentaro1043
requested changes
Jul 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
service.yaml
でkompose
と書いてあるところを、このコミットでやってるみたいに変えて欲しいです!
3781ba1
Kentaro1043
reviewed
Jul 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ありがとう!!
作業時にApproveします |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
portal-devのdeployment.yamlから不要部分を削除
ラベル名を生成されたものから変更
#845 と同様の変更です
part of #822