Skip to content

Expanded on the .npcbot list spawned command #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: npcbots_3.3.5
Choose a base branch
from

Conversation

Conan1996-2
Copy link

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

Issues Addressed:

  • None

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

  • Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue

I created a fork from:
https://github.com/trickerer/AzerothCore-wotlk-with-NPCBots/

my fork:
https://github.com/Conan1996-2/AzerothCore-wotlk-with-NPCBots

and added small code to filter class or location if you are interested.

This will show bots in your area
.npcbot list spawned in

This will show bots at a location like "Stormwind City"
.npcbot list spawned in full location name

This will show bots of a specific class, like "Warlock"
.npcbot list spawned class full class name

This will show bots at a specific level like 70
.npcbot list spawned level #

This will show bots within a range of levels, like 29-35
.npcbot list spawned level #-#

This will show how many bots of each class and each 10 level range.
.npcbot list spawned stats

examples of usage would be:
.npcbot list spawned in
.npcbot list spawned in redridge mountains
.npcbot list spawned class death knight
.npcbot list spawned level 70
.npcbot list spawned level 1-39
.npcbot list spawned stats

with both "class" and "level", you can use the "in full location name" to further filter.
.npcbot list spawned level 11-70 in dun morogh
.npcbot list spawned class warrior in dun morogh

Known Issues and TODO List:

  • - TODO: Add the 'in full location name' to the stats command, example: .nopcbot list spawned stats in Stormwind City

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

Added commands to .npcbot list spawned <new commands>

This will show bots in your area
.npcbot list spawned map

This will show bots at a location like "Stormwind City"
.npcbot list spawned map full location name

This will show bots of a specific class, like "Warlock"
.npcbot list spawned class full class name

This will show bots at a specific level like 70
.npcbot list spawned level #

This will show bots within a range of levels, like 29-35
.npcbot list spawned level #-#

This will show how many bots of each class and each 10 level range.
.npcbot list spawned stats

examples of usage would be:
.npcbot list spawned map
.npcbot list spawned map redridge mountains
.npcbot list spawned class death knight
.npcbot list spawned level 70
.npcbot list spawned level 1-39
.npcbot list spawned stats

with both "class" and "level", you can use the "in full location name" to further filter.
.npcbot list spawned level 11-70 in dun morogh
.npcbot list spawned class warrior in dun morogh
Changed the "map" to "in" command
Added 'in' keywork to stats command, only show stats with a count greater than 0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant