Retry JdbcClient::execute method #26231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That way it is easy to simply call a plain query execution on remote database.
So far we were doing a retry only when the connection opening had intermittent failure. Notice this is a best effort retrying. There is another execute method in BaseJdbcClient, however it is not a trivial thing to retry on statement execution there as it is not safe to retry it without opening a new connection.
kokosing
force-pushed
the
origin/master/003_retry
branch
from
a79d1e3 to
5a4132c
Compare
ebyhr
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retry JdbcClient::execute method
So far we were doing a retry only when the connection opening had
intermittent failure.
Notice this is a best effort retrying. There is another execute method
in BaseJdbcClient, however it is not a trivial thing to retry on
statement execution there as it is not safe to retry it without opening
a new connection.