Add support for TIMESTAMP and TIMESTAMP WITH TIME ZONE types in Exasol connector #26259

skyglass · 2025-07-22T09:51:36Z

Description

Added Exasol Trino connector support for Timestamp and Timestamp With Local Time Zone JDBC data types

Additional context and related issues

added correspondent tests for timestamp with precision data type
added correspondent tests for timestamp with local time zone with precision data type
implemented special addRoundTrip method with additional column expression parameter for the predicate to fix the test predicate assumption
all timestamp with timezone tests use input literal timestamp string, which is interpreted as a JVM timestamp string ("America/Bahia_Banderas") but expected literal strings are interpreted as UTC strings. Therefore the difference between these timestamps is 6 hours (with DST) or 5 (without DST); for some historical values, like 1970 for example, the difference can be 7, which is expected behaviour for timestamp with local time zone

Release notes

## Exasol Connect
* Add support for `timestamp` and `timestamp with time zone` types.

cla-bot · 2025-07-22T09:51:40Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2025-07-22T09:54:50Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2025-07-22T10:03:47Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2025-07-22T16:41:23Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2025-07-23T08:59:47Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2025-07-23T10:02:11Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2025-07-23T14:12:40Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

plugin/trino-exasol/src/main/java/io/trino/plugin/exasol/ExasolClient.java

testing/trino-product-tests/src/main/java/io/trino/tests/product/exasol/TestExasol.java

docs/src/main/sphinx/connector/exasol.md

plugin/trino-exasol/src/main/java/io/trino/plugin/exasol/ExasolClient.java

plugin/trino-exasol/src/test/java/io/trino/plugin/exasol/TestExasolTypeMapping.java

cla-bot · 2025-07-24T12:14:48Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2025-07-24T12:16:52Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2025-07-24T14:52:08Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2025-07-24T14:53:02Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2025-07-24T14:54:00Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2025-07-24T15:03:50Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2025-07-24T15:05:47Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

plugin/trino-exasol/src/test/java/io/trino/plugin/exasol/TestExasolTypeMapping.java

cla-bot · 2025-07-25T08:41:33Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2025-07-25T09:36:45Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

skyglass · 2025-07-25T18:36:22Z

plugin/trino-exasol/src/main/java/io/trino/plugin/exasol/ExasolClient.java

                    throws SQLException
            {
-                LocalDateTime localDateTime = fromTrinoTimestamp(epochMicros);
-                Timestamp timestampValue = Timestamp.valueOf(localDateTime);
+                long epochMillis = unpackMillisUtc(dateTimeWithTimeZone);


During final debugging it was discovered that longTimestampWithTimeZoneWriteFunction is never called. Therefore, I had to fix the tests, which fixed the calling of longTimestampWithTimeZoneWriteFunction.
After fixing the test, the bug with longTimestampWithTimeZoneWriteFunction has been discovered and fixed.

I have created additional commit, but will squash it into the main commit after the review.

skyglass · 2025-07-25T18:38:30Z

plugin/trino-exasol/src/test/java/io/trino/plugin/exasol/TestExasolTypeMapping.java

+                .addRoundTrip("timestamp(3) with local time zone", "TIMESTAMP '2018-10-28 01:33:17.456'", createTimestampWithTimeZoneType(3), "TIMESTAMP '2018-10-28 07:33:17.456 UTC'")
+                .addRoundTrip("timestamp(3) with local time zone", "TIMESTAMP '2018-10-28 03:33:33.333'", createTimestampWithTimeZoneType(3), "TIMESTAMP '2018-10-28 09:33:33.333 UTC'")
+                .addRoundTrip("timestamp(3) with local time zone", "TIMESTAMP '1970-01-01 00:13:42.000'", createTimestampWithTimeZoneType(3), "TIMESTAMP '1970-01-01 07:13:42.000 UTC'")
+                //'2018-04-01 02:13:55.123' is a DST gap time, which doesn't "exist" in the session time zone


The issue with "DST gap time" has been discovered by the fixed test, which might point to the incorrect conversion in exasol core db server, or it might be the issue with the testing framework. The test is disabled until further research.

In practice, the dst gap times should not happen, unless the timestamp is invalid, so this test case is not relevant and can be safely ignored

skyglass · 2025-07-29T18:41:32Z

plugin/trino-exasol/src/main/java/io/trino/plugin/exasol/ExasolClient.java

+            }
+
+            @Override
+            public void set(PreparedStatement statement, int index, long dateTimeWithTimeZone)


Any updates on the review?
I kept the separate commit to explain the latest changes and the bug, which was revealed by tests and fixed in this commit. I will combine this commit with the main one, as soon as you confirm the last changes.

github-actions bot added the exasol Exasol connector label Jul 22, 2025

skyglass force-pushed the feature/724_timestamp_data_types branch from 37a2fe5 to 78d1495 Compare July 22, 2025 10:03

skyglass mentioned this pull request Jul 22, 2025

[Closed Duplicate] Add support for TIMESTAMP and TIMESTAMP WITH TIME ZONE types in Exasol connector #26255

Closed

skyglass changed the title ~~Add support for TIMESTAMP and TIMESTAMP WITH TIME ZONE types in Exasol connector~~ [Closed Duplicate] Add support for TIMESTAMP and TIMESTAMP WITH TIME ZONE types in Exasol connector Jul 22, 2025

skyglass changed the title ~~[Closed Duplicate] Add support for TIMESTAMP and TIMESTAMP WITH TIME ZONE types in Exasol connector~~ Add support for TIMESTAMP and TIMESTAMP WITH TIME ZONE types in Exasol connector Jul 22, 2025

dekimir mentioned this pull request Jul 22, 2025

Test PR 2 dekimir/trino#2

Open

skyglass force-pushed the feature/724_timestamp_data_types branch from c950205 to d7ff56f Compare July 23, 2025 08:59

github-actions bot added the docs label Jul 23, 2025

skyglass force-pushed the feature/724_timestamp_data_types branch from ef6b95a to 07a421f Compare July 23, 2025 14:12

ebyhr reviewed Jul 23, 2025

View reviewed changes

skyglass force-pushed the feature/724_timestamp_data_types branch from 07a421f to 0d4b20a Compare July 24, 2025 12:14

skyglass force-pushed the feature/724_timestamp_data_types branch from 0d4b20a to bd554f9 Compare July 24, 2025 12:16

skyglass force-pushed the feature/724_timestamp_data_types branch from bd554f9 to 4ff3087 Compare July 24, 2025 14:52

skyglass force-pushed the feature/724_timestamp_data_types branch from 2a722d5 to 2c0b293 Compare July 24, 2025 15:05

chenjian2664 reviewed Jul 25, 2025

View reviewed changes

plugin/trino-exasol/src/test/java/io/trino/plugin/exasol/TestExasolTypeMapping.java Show resolved Hide resolved

skyglass force-pushed the feature/724_timestamp_data_types branch from 2c0b293 to cb525e5 Compare July 25, 2025 08:41

skyglass force-pushed the feature/724_timestamp_data_types branch from cb525e5 to b5ca512 Compare July 25, 2025 09:36

skyglass force-pushed the feature/724_timestamp_data_types branch from b5ca512 to 14ff13d Compare July 25, 2025 18:31

cla-bot bot added the cla-signed label Jul 25, 2025

skyglass commented Jul 25, 2025

View reviewed changes

skyglass force-pushed the feature/724_timestamp_data_types branch 2 times, most recently from 54b2f89 to 41f8576 Compare July 29, 2025 18:36

skyglass commented Jul 29, 2025

View reviewed changes

skyglass added 4 commits July 30, 2025 15:53

Add support for TIMESTAMP types in Exasol connector

54422c6

Fix checkstyle violations after enabling checkstyle plugin

88b59fe

Update exasol db version to 8.34.0 in tests

4dd47a8

Fix longTimestampWithTimeZoneWriteFunction and adapt the tests

7ad796f

skyglass force-pushed the feature/724_timestamp_data_types branch from 41f8576 to 7ad796f Compare July 30, 2025 13:53

Add support for TIMESTAMP and TIMESTAMP WITH TIME ZONE types in Exasol connector #26259

Are you sure you want to change the base?

Add support for TIMESTAMP and TIMESTAMP WITH TIME ZONE types in Exasol connector #26259

Uh oh!

Conversation

skyglass commented Jul 22, 2025

Description

Additional context and related issues

Release notes

Uh oh!

cla-bot bot commented Jul 22, 2025

Uh oh!

cla-bot bot commented Jul 22, 2025

Uh oh!

cla-bot bot commented Jul 22, 2025

Uh oh!

cla-bot bot commented Jul 22, 2025

Uh oh!

cla-bot bot commented Jul 23, 2025

Uh oh!

cla-bot bot commented Jul 23, 2025

Uh oh!

cla-bot bot commented Jul 23, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cla-bot bot commented Jul 24, 2025

Uh oh!

cla-bot bot commented Jul 24, 2025

Uh oh!

cla-bot bot commented Jul 24, 2025

Uh oh!

cla-bot bot commented Jul 24, 2025

Uh oh!

cla-bot bot commented Jul 24, 2025

Uh oh!

cla-bot bot commented Jul 24, 2025

Uh oh!

cla-bot bot commented Jul 24, 2025

Uh oh!

Uh oh!

cla-bot bot commented Jul 25, 2025

Uh oh!

cla-bot bot commented Jul 25, 2025

Uh oh!

skyglass Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

skyglass Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

skyglass Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

skyglass Jul 29, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

skyglass Jul 29, 2025 •

edited

Loading