[Hopper][WS] Add TaskIdPropagate pass #7038
Conversation
| @@ -0,0 +1,99 @@ | |||
| #ifndef TRITON_ANALYSIS_TASKIDPROPAGATION_H | |||
There was a problem hiding this comment.
can we keep this in WarpSpecialization folder?
[Hopper][WS] Add TaskIdPropagate pass
ardaunal
changed the title
| @@ -0,0 +1,99 @@ | |||
| #ifndef NVHOPPER_ANALYSIS_TASKIDPROPAGATION_H | |||
There was a problem hiding this comment.
sorry for nitpicking more but if this is only meant to be used in Transforms/WarpSpecialization the header doesn't need to be public (doesn't need to be include folder). I would move everything into Transforms/WarpSpecialization to keep it clear that this code is not meant to be used outside the WS mega-pass
There was a problem hiding this comment.
No problem but I am getting concerned that directory structure will get messier when we add more under WarpSpecialization. I was actually considering to separate Utility header as well as a part of a future clean-up.
There was a problem hiding this comment.
I think it would be nice to keep warp things related to warp specialization together, things can still be separated into multiple files but if there is no plan to use it outside of warp specialization it is better to keep it in the isolated.
[Hopper][WS] Add TaskIdPropagate pass
[Hopper][WS] Add TaskIdPropagate pass
|
Is the GB200 test broken in tot? The test failure doesn't seem to be related to this PR. |
This change adds a pass to propagate
async_task_ids from anchor ops using a sparse backward dataflow analysis.