Skip to content

Conversation

imrishabh18
Copy link
Member

@imrishabh18 imrishabh18 commented May 25, 2025

Screen.Recording.2025-05-26.at.2.20.30.AM.mov

Copy link

vercel bot commented May 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pcb-viewer ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 25, 2025 10:32pm

Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have mixed feelings about this because i think it's kind of confusing as is- we need to completely change the "Move Components" interaction model. I would create a new EditOverlayWithGroupSelection and focus on the interaction model for this new variant rather than porting the old edit system (which has this confusing step where we highlighting the group even though you can't click it). We can then turn on this different EditOverlay conditionally inside of stories while we develop the new approach (which doesn't have proper edit event support etc. so can't be released right away with just changes to this repo- it's a good choice for a feature flag prop)

When you click a component, a component becomes selected. Until you click either inside the group (selecting the group) or outside the group (unselecting everything) we continue to highlight.

When moving an entire group, every sub component's pcb_x and pcb_y changes together, along with the group pcb_x/pcb_y.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants