feat(viewer): generate circuitJsonKey from per-element bounds and refactor into util #356
+58
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abimaelmartell
requested review from
seveibar and
ShiboSoftwareDev
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
…d vitest script" This reverts commit f62dd99.
seveibar
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors how the
circuitJsonKeyis computed inPCBViewer.Instead of relying on the array length and
editCount, we now generate a stable, content-based key using a new utility:calculateCircuitJsonKey.Changes
lib/calculate-circuit-json-key.ts:pcb_elements in the circuit JSON.PCBViewer.tsx:circuitJsonKeycalculation withuseMemo(calculateCircuitJsonKey).circuitJsonchanges.