Skip to content

Clean up encryption configuration and also add support for encryption via connection string #2159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Clean up encryption configuration and also add support for encryption via connection string #2159

wants to merge 3 commits into from

Conversation

avinassh
Copy link
Member

@avinassh avinassh commented Sep 7, 2025 •
edited
Loading

This is a follow up from the PR #2155

  1. The previous introduced a flag LIBSQL_ENCRYPTION to add sqlite3mc's methods. It seems we already had some plumbing in the place behind the flag LIBSQL_EXTRA_URI_PARAMS just that it wasn't integrated fully. So in this PR, I removed the LIBSQL_ENCRYPTION flag and instead use LIBSQL_EXTRA_URI_PARAMS
  2. I added the methods required for LIBSQL_EXTRA_URI_PARAMS
  3. This PR also enables encryption parameters via connection URI
  4. Added a regression test for the same

@avinassh avinassh marked this pull request as ready for review September 7, 2025 17:44
@avinassh avinassh requested a review from penberg September 7, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@penberg penberg Awaiting requested review from penberg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@avinassh