Add cluster support #228
Open
Add cluster support #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farost
commented
Jun 17, 2025
| string distribution = 1; | ||
| string version = 2; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| message Server { |
There was a problem hiding this comment.
I don't think we need a separate ServerReplica message
farost
commented
Jun 17, 2025
| string address = 1; | ||
| } | ||
|
|
||
| message Version { |
There was a problem hiding this comment.
Generally, it should be same for every server in the cluster, but its domain is closer to Server
farost
commented
Jun 18, 2025
| Authentication.Token.Create.Req authentication = 4; | ||
| } | ||
|
|
||
| message Res { | ||
| uint64 server_duration_millis = 1; | ||
| ConnectionID connection_id = 2; | ||
|
|
||
| // pre-send all databases and replica info | ||
| DatabaseManager.All.Res databases_all = 3; |
There was a problem hiding this comment.
We removed an excessive cache, plus it's unclear which replica to trust in the first place, so we removed the databases from this initial response. The process of getting the databases will run through the regular APIs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes: usage and product changes
Introduce cluster support for TypeDB 3.x, featuring server replicas and the new version message.
Implementation
Remove database replicas. Instead, add server replicas (by extending the usual
Servermessage) with a similar set of fields.Instead of adding a
is_primaryflag, introduce an extensible enumReplicaTypefor more granular split between primary and supporting nodes.To reduce the network overhead, this new information is provided in the initial server's connection response.