Fix Tauri app builds for x86_64 Mac #888
Merged
+30
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for typedb-studio ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Comment on lines
+117
to
+118
| git rev-parse HEAD > VERSION | ||
| bazel run --define version=$(git rev-parse HEAD) //:deploy-mac-<<parameters.target-arch>>-dmg -- snapshot |
There was a problem hiding this comment.
git rev-parse HEAD > VERSION wouldn't be needed, but i can't get --define version=$(git rev-parse HEAD) to work for whatever reason.
There was a problem hiding this comment.
In that case presumably we don't need --define version=$(git rev-parse HEAD) here?
alexjpwalker
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes: product changes
Fix the build pipeline so Mac x86_64 builds are actually built for the x86_64 architecture. They were previously being built targeting the arm64 architecture (the native architecture of the CircleCI executor)
Motivation
Support mac x86_64
Implementation
Plumbing around adding
--target x86_64-apple-darwintonpx tauri buildGreen run for snapshot deployments: https://app.circleci.com/pipelines/github/typedb/typedb-studio/1966/workflows/b614b09a-ba5d-467b-b1b5-51628a4dc6c2