-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Edited pyproject.toml to support uvx #1289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughA new command-line script entry point named Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
pyproject.toml (2)
20-36
: Duplicate dependencies inflate wheels and slow installs
playwright
andaiofiles
are each declared twice (lines 21 & 35, 28 & 36). This is benign forpip
, but:• Increases file size of generated lock files
• Makes dependency counts look inflated in dependency-scanning tools
• Signals potential cut-&-paste errors to maintainersConsider pruning the duplicates:
- "playwright>=1.49.0", … - "aiofiles>=24.1.0", … - "playwright", - "aiofiles", + "playwright>=1.49.0", + "aiofiles>=24.1.0",
65-74
: Optional-deps groupall
contains a duplicatePyPDF2
The package is already listed at the top of the
all
array. Removing the second occurrence avoids needless churn in lock files.- "selenium", - "PyPDF2" + "selenium"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pyproject.toml
(1 hunks)
🔇 Additional comments (1)
pyproject.toml (1)
82-82
: Alias is fine, but double-check for documentation & packaging consistencyAdding an additional
crawl4ai
script that points to the same entry point ascrwl
is harmless and gives users a more intuitive command.
Please verify:
- README / docs reference the new command so users are aware.
- Down-stream images / Dockerfiles or CI jobs that still call
crwl
continue to work.- No packaging tools (e.g. Homebrew formula, Debian package) assume the executable’s singular name.
If all three check out, no further action is needed.
No major change has been done
Summary by CodeRabbit
crawl4ai
. This provides an alternative way to launch the application from the terminal.