-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
fix VersionManager not using CRAWL4_AI_BASE_DIRECTORY #1296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
crawl4ai/utils.py (1)
229-229
: ✅ Good fix for the split-brain scenario, but consider type consistency.This change correctly addresses the issue where
VersionManager
wasn't respecting theCRAWL4_AI_BASE_DIRECTORY
environment variable. However, there's a minor type inconsistency in the implementation.The current implementation mixes types:
os.getenv()
returns a string when the environment variable is set, butPath.home()
returns aPath
object when it's not set. While thePath()
constructor handles both, it's cleaner to be consistent:-self.home_dir = Path(os.getenv("CRAWL4_AI_BASE_DIRECTORY", Path.home())) +self.home_dir = Path(os.getenv("CRAWL4_AI_BASE_DIRECTORY") or Path.home())or
-self.home_dir = Path(os.getenv("CRAWL4_AI_BASE_DIRECTORY", Path.home())) +self.home_dir = Path(os.getenv("CRAWL4_AI_BASE_DIRECTORY", str(Path.home())))
Summary
VersionManager
did not do an eval ofCRAWL4_AI_BASE_DIRECTORY
env variable unlike actual database manager,so it caused split-brain scenario where database was written in folder specified by env variable,
followed by failure to write
version.txt
since that was force-attempted in users home folder.List of files changed and why
utils.py:
Checklist:
Summary by CodeRabbit