-
-
Notifications
You must be signed in to change notification settings - Fork 16
Inflection 85 - Add Malayalam Inflection and Pronoun Tests #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Inflection 85 - Add Malayalam Inflection and Pronoun Tests #122
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good progress. It looks like the pipeline checks aren't running. I'd expect the inflection tests to not pass the tests without a MlGrammarSynthesizer_MlDisplayFunction implementation.
Are you running the tests?
@@ -0,0 +1,5 @@ | |||
# | |||
# Copyright 2016-2024 Apple Inc. All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please switch these comments on the new files to be
Copyright 2025 Unicode Incorporated and others. All rights reserved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I'm almost finished with the grammar synthesizer. How do I run the tests for the inflection and pronoun? Additionally, how do I see if the pipeline checks are running?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run make check locally. The details are in the readme.
https://github.com/unicode-org/inflection/blob/main/inflection/README.md#build-instructions
Added numerous test cases for Malayalam inflection and pronouns