Skip to content

docs: remove initializelogging calls from suggested migration code #20730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2025

Conversation

kazo0
Copy link
Contributor

@kazo0 kazo0 commented Jun 6, 2025

We should not include the App.InitializeLogging() call in the migration code for Skia rendered app. It is misleading as this method may not always exist in the App.xaml.cs depending on the template used

@Copilot Copilot AI review requested due to automatic review settings June 6, 2025 12:55
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the App.InitializeLogging() calls from the migration code in the Uno 6 documentation to prevent confusion among developers using different project templates.

  • Removed App.InitializeLogging() call from the "Main" methods in multiple code examples.
  • Updates the documentation to ensure the sample code matches the appropriate template usage.

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-20730/docs/index.html

Copy link
Contributor

@ajpinedam ajpinedam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-20730/docs/index.html

@kazo0
Copy link
Contributor Author

kazo0 commented Jun 13, 2025

@Mergifyio backport release/stable/6.0

@kazo0 kazo0 merged commit 97fc65e into master Jun 13, 2025
12 checks passed
@kazo0 kazo0 deleted the dev/sb/uno6-logging-code branch June 13, 2025 16:22
Copy link
Contributor

mergify bot commented Jun 13, 2025

backport release/stable/6.0

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants