fix log_warning function call with missing arguments #1494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxmb
force-pushed
the
fix-process-warnings
branch
2 times, most recently
from
834a426 to
08bbdb1
Compare
oxmb
changed the title
Fixed TypeError in warnings.py where log_warning was called with only 2 arguments instead of the required 4 positional arguments (logger, message, subtype, location). This was causing crashes when processing invalid warning filters in Sphinx 8.x. The fix ensures compatibility with the updated log_warning function signature introduced for Sphinx 8.x compatibility.
oxmb
force-pushed
the
fix-process-warnings
branch
from
08bbdb1 to
a7d436a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix log_warning function call with missing arguments
Fix for #1493
Summary
sphinx_needs/warnings.py:80wherelog_warningwas called with only 2 arguments instead of the required 4 positional argumentslog_warningfunction signatureRoot Cause
The
log_warningfunction signature insphinx_needs/logging.pyexpects 4 positional arguments:logger(SphinxLoggerAdapter)message(str)subtype(WarningSubTypes)location(str | tuple | Node | None)However, the call on line 80 of
warnings.pywas only passing 2 arguments:Fix Applied
Updated the problematic call to include the missing required arguments:
Tests
pytest tests/ -k "warning")