First version of "completion" design

[PieterOlivier]

The design is documented using "description" sections in LanguageServer.rsc. Feedback on the documentation as well as the design is appreciated!

[toinehartman]

I am excited to see this in action! Since we already discussed this design together, my comments mostly consider documentation and naming.

[DavyLandman]

It's looking good, it's not a small API, but it's looking good.

[jurgenvinju]

It would perhaps be good to test drive this contribution with a generic function that takes a reified grammar and produces a simplified syntax directed completion contribution function (based on error trees or normal trees). To be used as completion(syntaxDirectedCompletion(#start[Program])) for example for Pico?

That way we can see if the LSP side fits on the Rascal side with what we have in mind. Or if we still need to think more about the Rascal side.

[DavyLandman]

I've discussed the design choice of merging the 2 LSP enums into one ADT with @jurgenvinju and he agrees that in the end it's the cleanest solution. It's not 100% ideal, but the alternatives are worse for the end users.

He indicated he would take a final look at the rest of the API today, as he had some concerns and wanted to verify how they were addressed.

[jurgenvinju]

Love it

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud