Remember files opened as `Parametric Rascal LSP` before language registration #809

toinehartman · 2025-10-01T12:21:24Z

This PR keeps track of files that are open with language Parametric Rascal LSP, for which there is no language registered yet. Once the user registers a language, we update the associated open editors.

This PR closes #795.

Keep track of files that are classified as 'Parametric Rascal MPL' language, but with an unknown extension. Once someone registers this extension, store the file state and update the editor as if they were opened *after* registering the language.

rascal-lsp/src/main/java/org/rascalmpl/vscode/lsp/parametric/ParametricTextDocumentService.java

DavyLandman

I think this PR is a bit involved, as in it requires many places to take into account possible race between registry & availability of the language. Especially if someone later adds a new capability, it'll soon be forgotten.

I'm thinking there might be a way to make a subclass of our ParsingOnlyContribution (like EmptyContribution) and then connect that to the incoming file. and when a registry comes in, we update all the existing mappings to the new contribution?

rascal-lsp/src/main/java/org/rascalmpl/vscode/lsp/parametric/ParametricTextDocumentService.java

…-race

rascal-lsp/src/main/java/org/rascalmpl/vscode/lsp/TextDocumentState.java

DavyLandman

I like how small this got in the end.

rascal-lsp/src/main/java/org/rascalmpl/vscode/lsp/parametric/ParametricTextDocumentService.java

…-race

DavyLandman

This doesn't feel complete to me, or else I'm missing some connections.

rascal-lsp/src/main/java/org/rascalmpl/vscode/lsp/parametric/NoContributions.java

rascal-lsp/src/main/java/org/rascalmpl/vscode/lsp/parametric/ParametricTextDocumentService.java

…-race

DavyLandman

Yes, this is much better, I have some small questions and stuff we need to improve.

rascal-lsp/src/main/java/org/rascalmpl/vscode/lsp/parametric/NoContributions.java

rascal-lsp/src/main/java/org/rascalmpl/vscode/lsp/parametric/ParametricTextDocumentService.java

…-race

This reverts commit 27a6410.

sonarqubecloud · 2025-10-15T12:53:35Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

DavyLandman

Two small questions, for the rest it looks find

DavyLandman · 2025-10-15T17:39:04Z

rascal-lsp/src/main/java/org/rascalmpl/vscode/lsp/parametric/ParametricTextDocumentService.java

-        );
+        var loc = Locations.toLoc(doc);
+        return files.computeIfAbsent(loc,
+            l -> new TextDocumentState(contributions(loc)::parsing, l, doc.getVersion(), doc.getText(), timestamp));


l and loc are the same, no need to capture them from outside the closure.

(I don't see why we need this change?)

DavyLandman · 2025-10-15T17:42:41Z

rascal-lsp/src/main/java/org/rascalmpl/vscode/lsp/TextDocumentState.java

+                        diagnosticsAsync.complete(diagnostics);
+                    });
+            } catch (NoContributionException e) {
+                logger.debug("Ignoring missing parser for {}", location, e);


Is it no problem that treeAsync is never completed?

toinehartman added 2 commits October 1, 2025 10:23

Check for valid state before getting files.

ec1363b

toinehartman self-assigned this Oct 1, 2025

toinehartman added the bug Something isn't working label Oct 1, 2025

toinehartman changed the title ~~Remember files opened as 'Parametric Rascal MPL before language registration~~ Remember files opened as Parametric Rascal MPL before language registration Oct 1, 2025

toinehartman changed the title ~~Remember files opened as Parametric Rascal MPL before language registration~~ Remember files opened as Parametric Rascal LSP before language registration Oct 1, 2025

PieterOlivier reviewed Oct 1, 2025

View reviewed changes

rascal-lsp/src/main/java/org/rascalmpl/vscode/lsp/parametric/ParametricTextDocumentService.java Outdated Show resolved Hide resolved

DavyLandman requested changes Oct 2, 2025

View reviewed changes

rascal-lsp/src/main/java/org/rascalmpl/vscode/lsp/parametric/ParametricTextDocumentService.java Outdated Show resolved Hide resolved

rascal-lsp/src/main/java/org/rascalmpl/vscode/lsp/parametric/ParametricTextDocumentService.java Outdated Show resolved Hide resolved

toinehartman added 2 commits October 2, 2025 11:52

Use dummy parser instead of separate open file bookkeeping.

2d7b93c

Reset parser.

ce5aee8

DavyLandman marked this pull request as draft October 2, 2025 19:18

This was referenced Oct 5, 2025

Reregistering sometimes produces an exception: "Unknown file" #818

Closed

If a DSL file is already open when it's registered, the user gets a whole lot of error messages #795

Open

toinehartman added 2 commits October 6, 2025 16:10

Simplify updating open files.

ab6e7c6

Re-use newly introduced language helpers.

1a0da53

toinehartman force-pushed the fix/795-open-register-race branch from 5c9467d to 1a0da53 Compare October 6, 2025 14:16

Merge remote-tracking branch 'origin/main' into fix/795-open-register…

8d8b675

…-race

toinehartman commented Oct 6, 2025

View reviewed changes

rascal-lsp/src/main/java/org/rascalmpl/vscode/lsp/TextDocumentState.java Outdated Show resolved Hide resolved

Replace state instead of updating parser.

65bd32f

toinehartman marked this pull request as ready for review October 6, 2025 14:43

DavyLandman approved these changes Oct 6, 2025

View reviewed changes

toinehartman added 9 commits October 9, 2025 13:38

Exception instead of incomplete future.

e9f791a

Merge remote-tracking branch 'origin/main' into fix/795-open-register…

bee0669

…-race

Prevent 'no such file' errors using dummy contribution.

37c816c

Clean up declarations & imports.

da179cf

Prevent 'no such file' errors on analysis.

eaa412f

Register extension after contibution registration is done.

80b9fd3

Merge remote-tracking branch 'origin/main' into fix/795-open-register…

efaa03c

…-race

Extract updating file state to functions.

261bf55

Properly log analyzer triggers.

cfebe65

toinehartman requested review from DavyLandman and PieterOlivier October 14, 2025 06:33

DavyLandman requested changes Oct 14, 2025

View reviewed changes

toinehartman added 8 commits October 14, 2025 13:47

Reset language ID to re-trigger contributions.

b6380dd

Rewrite optional mapping.

eb973f0

Merge remote-tracking branch 'origin/main' into fix/795-open-register…

74b8451

…-race

Log port number when server fails.

252608f

Use precise replace to prevent races.

edb3302

Bump log level.

82b5b98

Document NoContributions.

73a479e

Fix SQ issues.

6485415

DavyLandman reviewed Oct 14, 2025

View reviewed changes

toinehartman added 8 commits October 15, 2025 11:03

Handle case where didClose or registerLanguage races with parser update.

c050228

Fixes from review by @DavyLandman.

f9b8582

Associate empty contributions with extension.

4781d0c

Throw exceptions on methods that are not intended to be called.

27a6410

Merge remote-tracking branch 'origin/main' into fix/795-open-register…

756bb02

…-race

Refactor and fix SQ warnings.

e20ddde

Revert "Throw exceptions on methods that are not intended to be called."

0e1ac0d

This reverts commit 27a6410.

Do not wrap exceptions in futures.

6e9be85

DavyLandman requested changes Oct 15, 2025

View reviewed changes

Remember files opened as Parametric Rascal LSP before language registration #809

Are you sure you want to change the base?

Remember files opened as Parametric Rascal LSP before language registration #809

Uh oh!

Conversation

toinehartman commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

DavyLandman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DavyLandman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DavyLandman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DavyLandman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Oct 15, 2025

Quality Gate passed

Uh oh!

DavyLandman left a comment

Choose a reason for hiding this comment

Uh oh!

DavyLandman Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

DavyLandman Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Remember files opened as `Parametric Rascal LSP` before language registration #809

Remember files opened as `Parametric Rascal LSP` before language registration #809

toinehartman commented Oct 1, 2025 •

edited

Loading