Skip to content

experiment: add dashboard base styles and visual tests #9679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

web-padawan
Copy link
Member

Description

  • Added mostly functional styles for widget and section (borders, outlines) and icon controls.
  • Didn't include Lumo specific properties e.g. --_widget-filter and --_widget-opacity.

Type of change

  • Experiment

@web-padawan web-padawan requested a review from jouni July 10, 2025 10:40
Copy link

@jouni
Copy link
Member

jouni commented Jul 11, 2025

Visually, this looks good 👍. Didn't take a look at the CSS, but I assume it’s mostly copied from existing styles.

Copy link
Member

@jouni jouni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d like to see the listing of new custom properties we add. Forced color mode should be fixed, as the button icons are invisible.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The header might benefit from a gap between the title and the custom header content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants