Spelling #21
Open
Spelling #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
jsoref
commented
Jun 9, 2025
| @@ -67,7 +67,7 @@ private Socket connectToFirstSuccessfulHost(HostAndPort hostAndPort) throws Exce | |||
|
|
|||
| socket.setReuseAddress(true); | |||
| socket.setKeepAlive(true); // Will monitor the TCP connection is valid | |||
| socket.setTcpNoDelay(true); // Socket buffer Whetherclosed, to ensure timely delivery of data | |||
There was a problem hiding this comment.
This is a very old corruption:
| * that's simple to parse by computers and easy to read by humans. | ||
| * <p> | ||
| * <b>Format of the returned String:</b> | ||
| * <p> | ||
| * All the fields are in the form field:value | ||
| * | ||
| * <pre> | ||
| * edis_version:0.07 |
| @@ -5527,7 +5527,7 @@ public long msetnx(final String... keysvalues) { | |||
| } | |||
|
|
|||
| /** | |||
| * IDECRBY work just like {@link Jedis#decr(String) INCR} but instead to decrement by 1 the | |||
| @@ -1384,7 +1384,7 @@ public void zinterstore() { | |||
| } | |||
|
|
|||
| @Test | |||
| public void zintertoreParams() { | |||
There was a problem hiding this comment.
Spotting this required adding a pattern to ignore z prefixes and then recognizing that it was an interesting typo...
| @@ -614,12 +614,12 @@ public void xack() { | |||
|
|
|||
| @Test | |||
| public void xpendingWithParams() { | |||
| final String stream = "xpendeing-stream"; | |||
There was a problem hiding this comment.
I'm reasonably confident this is a typo...
| @@ -232,7 +232,7 @@ public void testJsonMerge() { | |||
|
|
|||
| assertJsonArrayEquals(jsonArray(json), jsonV2.jsonGet("test_merge", Path2.of("$"))); | |||
|
|
|||
| // Test with root path path $.a.b | |||
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.