Float pkg: Decouple ki config value from the loop time. #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolwheel
force-pushed
the
decouple_pids_from_imu_loop_time
branch
from
7b095d0 to
23f440e
Compare
Going into the future the ki will "feel" like as it would have if the loop frequency was 832 Hz - the default loop frequency of Float pkg.
|
@surfdado Is it ok to merge this one? |
|
I consider the Float package obsolete, all our efforts are on Refloat now. I suggest @lolwheel submit this in lukash/refloat instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going into the future the ki will "feel" like as it would have if the loop frequency was 832 Hz - the default loop frequency of Float pkg.