feat: support infer function parameter type from initial value #2283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurfiorette
requested changes
Jun 21, 2025
| }), | ||
| false, | ||
| ); | ||
| } | ||
|
|
||
| function getParameterName(node: ts.BindingName, index: number) { | ||
| if (node.parent) { |
There was a problem hiding this comment.
Suggested change
| if (node.parent) { | |
| if (node.parent && node.pos !== -1) { |
Programatically created nodes don't have text information.
There was a problem hiding this comment.
I don't get why the condition node.pos !== -1 should be added. node.parent should not be sufficient?
alexchexes
added a commit
to alexchexes/ts-json-schema-generator
that referenced
this pull request
Jun 23, 2025
…argument default - Work on inferring still in progress, arg with type function is not handled; + see the existing vega#2283
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2272