-
Notifications
You must be signed in to change notification settings - Fork 102
Debug issue from gh440 #444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Gave it a quick shot and I was able to go through the whole flow including duo push and get logged in. Unfortunately that's all I'll be able to get to today. That said, there is an error in JSON decoding (that ends up getting ignored) that i have not looked into other than to see that it's happening in the try/except you added:
Again, it ultimately lets me in with a push even with the above error. |
I get the same error - initially I thought it happened because I used the wrong response for it. Since I can reproduce with our setup as well - I can try to debug this. It would be nice if we could get the trace (run with debug logging) of the http request just before this error happens. Would be interesting to see the comparison between our two environments. - I think the error happening does mean, that it should work for your setup even if nothing is done with the response from this callback. I'll try to add a few command line switches or sth. to let us experiment with different procedures without requiring code changes every time. Thanks for taking the time to test this. |
Sure, np. You just looking for the block starting with something like |
That would be sufficient. I tried to reproduce the issue somewhat and improve logging but could not reproduce this anymore. I'd be looking for this part specifically, to understand why the response is not parsable as json "sometimes":
|
In #440 / #441 a callback was introduced. Using the response of the callback causes issues for our setup.
This MR is an attempt to debug the situation and hopefully finding a way that works for @thecaffiend as well as our setup.