-
Notifications
You must be signed in to change notification settings - Fork 28.5k
[turbopack] Remove uses of Value<..>
instead make the payloads impl Taskinput
#80142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: value_delenda_est_8
Are you sure you want to change the base?
Conversation
|
Value<..>
instead make the payloads impl Taskinput
CodSpeed Performance ReportMerging #80142 will degrade performances by 13.76%Comparing Summary
Benchmarks breakdown
|
f6bf8f5
to
382fabc
Compare
ea77fa5
to
4b1bd42
Compare
382fabc
to
73e17c7
Compare
0e215a1
to
83d97a7
Compare
73e17c7
to
e221fb3
Compare
83d97a7
to
c1a0ac0
Compare
e221fb3
to
752c02e
Compare
c1a0ac0
to
5b560c5
Compare
6bf0581
to
fc114ee
Compare
5b560c5
to
ea864f9
Compare
fc114ee
to
d250888
Compare
ea864f9
to
0ce102a
Compare
062d84c
to
3d1657f
Compare
4676376
to
a276676
Compare
3d1657f
to
ae677fd
Compare
8e6ff8c
to
d945e21
Compare
ae677fd
to
044d75c
Compare
d945e21
to
83946ab
Compare
044d75c
to
8217fad
Compare
8217fad
to
4a5b154
Compare
83946ab
to
6145af6
Compare
4a5b154
to
7d37602
Compare
6145af6
to
5431c2b
Compare
5431c2b
to
4fcc8ab
Compare
7d37602
to
4cd4144
Compare
4fcc8ab
to
cb8c651
Compare
858239f
to
c61a09f
Compare
cb8c651
to
f5ecc1b
Compare
c61a09f
to
299e43d
Compare
f5ecc1b
to
a7f44f6
Compare
299e43d
to
3658d10
Compare
4e4dca5
to
1796b21
Compare
3658d10
to
f1fbe01
Compare
1796b21
to
2413f40
Compare
e91fc1a
to
0e998b8
Compare
2413f40
to
dce0b1e
Compare
Remove uses of
Value<..>
instead make the payloads impl TaskinputWhy?
The Value<> type is confusing and error prone, lets destroy it!
As discussed over slack, turbo_tasks::Value type always implements is_resolved as true and is_transient as false which is incorrect and can enable smuggling transient vcs into turbo tasks.
• https://vercel.slack.com/archives/C03EWR7LGEN/p1743456121241529
• https://vercel.slack.com/archives/C04NGV98TPS/p1743455453764879