Skip to content

[turbopack] Remove uses of Value<..> instead make the payloads impl Taskinput #80142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: value_delenda_est_8
Choose a base branch
from

Conversation

lukesandberg
Copy link
Contributor

@lukesandberg lukesandberg commented Jun 4, 2025

Remove uses of Value<..> instead make the payloads impl Taskinput

Why?

The Value<> type is confusing and error prone, lets destroy it!

As discussed over slack, turbo_tasks::Value type always implements is_resolved as true and is_transient as false which is incorrect and can enable smuggling transient vcs into turbo tasks.

https://vercel.slack.com/archives/C03EWR7LGEN/p1743456121241529
https://vercel.slack.com/archives/C04NGV98TPS/p1743455453764879

@ijjk ijjk added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Jun 4, 2025
Copy link

changeset-bot bot commented Jun 4, 2025

⚠️ No Changeset found

Latest commit: a276676

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codspeed-hq bot commented Jun 4, 2025

CodSpeed Performance Report

Merging #80142 will degrade performances by 13.76%

Comparing value_delenda_est_9 (e48ca0d) with value_delenda_est_8 (0e998b8)

Summary

❌ 1 regressions
✅ 14 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
rcstr!/small 182.8 ns 211.9 ns -13.76%

@lukesandberg lukesandberg force-pushed the value_delenda_est_9 branch from f6bf8f5 to 382fabc Compare June 4, 2025 18:51
@lukesandberg lukesandberg force-pushed the value_delenda_est_8 branch from ea77fa5 to 4b1bd42 Compare June 4, 2025 18:51
@lukesandberg lukesandberg force-pushed the value_delenda_est_9 branch from 382fabc to 73e17c7 Compare June 4, 2025 21:03
@lukesandberg lukesandberg force-pushed the value_delenda_est_8 branch from 0e215a1 to 83d97a7 Compare June 4, 2025 21:07
@lukesandberg lukesandberg force-pushed the value_delenda_est_9 branch from 73e17c7 to e221fb3 Compare June 4, 2025 21:07
@lukesandberg lukesandberg force-pushed the value_delenda_est_8 branch from 83d97a7 to c1a0ac0 Compare June 4, 2025 21:13
@lukesandberg lukesandberg force-pushed the value_delenda_est_9 branch from e221fb3 to 752c02e Compare June 4, 2025 21:13
@lukesandberg lukesandberg marked this pull request as ready for review June 4, 2025 21:17
@lukesandberg lukesandberg requested a review from a team June 4, 2025 21:17
@lukesandberg lukesandberg force-pushed the value_delenda_est_8 branch from c1a0ac0 to 5b560c5 Compare June 4, 2025 22:19
@lukesandberg lukesandberg force-pushed the value_delenda_est_9 branch 2 times, most recently from 6bf0581 to fc114ee Compare June 4, 2025 22:20
@lukesandberg lukesandberg force-pushed the value_delenda_est_8 branch from 5b560c5 to ea864f9 Compare June 4, 2025 22:20
@lukesandberg lukesandberg force-pushed the value_delenda_est_9 branch from fc114ee to d250888 Compare June 4, 2025 22:24
@lukesandberg lukesandberg force-pushed the value_delenda_est_8 branch from ea864f9 to 0ce102a Compare June 4, 2025 22:24
@mischnic mischnic force-pushed the value_delenda_est_8 branch from 062d84c to 3d1657f Compare June 5, 2025 09:15
@mischnic mischnic force-pushed the value_delenda_est_9 branch from 4676376 to a276676 Compare June 5, 2025 09:15
@lukesandberg lukesandberg force-pushed the value_delenda_est_8 branch from 3d1657f to ae677fd Compare June 5, 2025 15:29
@lukesandberg lukesandberg force-pushed the value_delenda_est_9 branch 2 times, most recently from 8e6ff8c to d945e21 Compare June 5, 2025 19:50
@lukesandberg lukesandberg force-pushed the value_delenda_est_8 branch from ae677fd to 044d75c Compare June 5, 2025 19:50
@lukesandberg lukesandberg force-pushed the value_delenda_est_9 branch from d945e21 to 83946ab Compare June 5, 2025 22:21
@lukesandberg lukesandberg force-pushed the value_delenda_est_8 branch from 044d75c to 8217fad Compare June 5, 2025 22:21
@mischnic mischnic force-pushed the value_delenda_est_8 branch from 8217fad to 4a5b154 Compare June 5, 2025 22:52
@mischnic mischnic force-pushed the value_delenda_est_9 branch from 83946ab to 6145af6 Compare June 5, 2025 22:53
@mischnic mischnic force-pushed the value_delenda_est_8 branch from 4a5b154 to 7d37602 Compare June 6, 2025 00:46
@mischnic mischnic force-pushed the value_delenda_est_9 branch from 6145af6 to 5431c2b Compare June 6, 2025 00:47
@lukesandberg lukesandberg force-pushed the value_delenda_est_9 branch from 5431c2b to 4fcc8ab Compare June 6, 2025 02:22
@lukesandberg lukesandberg force-pushed the value_delenda_est_8 branch from 7d37602 to 4cd4144 Compare June 6, 2025 02:22
@lukesandberg lukesandberg force-pushed the value_delenda_est_9 branch from 4fcc8ab to cb8c651 Compare June 6, 2025 14:03
@lukesandberg lukesandberg force-pushed the value_delenda_est_8 branch from 858239f to c61a09f Compare June 6, 2025 14:05
@lukesandberg lukesandberg force-pushed the value_delenda_est_9 branch from cb8c651 to f5ecc1b Compare June 6, 2025 14:06
@lukesandberg lukesandberg force-pushed the value_delenda_est_8 branch from c61a09f to 299e43d Compare June 6, 2025 14:36
@lukesandberg lukesandberg force-pushed the value_delenda_est_9 branch from f5ecc1b to a7f44f6 Compare June 6, 2025 14:36
@lukesandberg lukesandberg force-pushed the value_delenda_est_8 branch from 299e43d to 3658d10 Compare June 6, 2025 16:08
@lukesandberg lukesandberg force-pushed the value_delenda_est_9 branch from 4e4dca5 to 1796b21 Compare June 6, 2025 16:09
@lukesandberg lukesandberg force-pushed the value_delenda_est_8 branch from 3658d10 to f1fbe01 Compare June 6, 2025 16:26
@lukesandberg lukesandberg force-pushed the value_delenda_est_9 branch from 1796b21 to 2413f40 Compare June 6, 2025 16:26
@lukesandberg lukesandberg force-pushed the value_delenda_est_8 branch 2 times, most recently from e91fc1a to 0e998b8 Compare June 6, 2025 22:21
@lukesandberg lukesandberg force-pushed the value_delenda_est_9 branch from 2413f40 to dce0b1e Compare June 6, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants