Skip to content

test coverage improvements #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Oct 7, 2025
Merged

test coverage improvements #43

merged 12 commits into from
Oct 7, 2025

Conversation

vertti
Copy link
Owner

@vertti vertti commented Oct 7, 2025

  • Extracted core/app.py - Moved 127 lines of navigation logic out of init.py
    • init.py reduced from 218 → 91 lines (58% reduction)
    • Separated business logic from CLI setup
    • All navigation state machines now testable
  • Extracted pure functions for testability:
    • build_log_group_arn() and build_log_stream_name() in container module
    • Action dispatcher functions with clear responsibilities
    • Better separation of concerns throughout
  1. Bug Fixes Found Through Testing
  • Fixed get_task_and_definition() - now handles missing taskDefinition response
  • Better error handling for edge cases across services
  1. Test Coverage Improvements

Test additions:

  • 62 new test files/functions added
  • 274 total tests (was 174)
  • All critical features now tested

vertti added 11 commits October 7, 2025 09:09
@vertti
add tests for core utils and container service
1d71da8
@vertti
refactor: extract navigation logic from __init__.py to core/app.py
c9f1b33 
  - Move all navigation loops and action dispatchers to new core/app.py module
  - Reduce __init__.py from 218 to 91 lines (58% reduction)
  - Extract testable action dispatch functions:
    - dispatch_container_action()
    - dispatch_task_action()
    - dispatch_service_action()
    - get_*_action_handlers() functions
  - Add 9 new tests for action dispatch logic in test_app.py
  - Update test_cli.py to mock new console location
@vertti
emphasize avoiding obvious comments and docstrings
974b5ec
@vertti
refactor: extract and test container log helper functions
69ef0cd
@vertti
test: add comprehensive tests for task failure analysis and formatting
6169762
@vertti
test: add comprehensive tests for services, UI wrappers, and containe…
380073e 
…r logs
@vertti
test: add comprehensive tests for app navigation logic
7cdd844
@vertti
test: add comprehensive tests for task comparison UI
86077fa
@vertti
refactor: clean up test files
ce829e9 
  - Remove obvious test docstrings that repeat function names
  - Consolidate mock_ecs_client fixture to conftest.py
  - Simplify test_extract_name_from_arn (14 lines → 4 lines)
  - Remove obvious comments and inline explanations
@vertti
refactor: simplify tests with parametrization and cleanup
9374b05
@vertti
fix multiple coveralls uploads
80ba49b
@vertti vertti merged commit 0f64d21 into main Oct 7, 2025
3 checks passed
@vertti vertti deleted the more-tests branch October 7, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@vertti