-
Notifications
You must be signed in to change notification settings - Fork 784
socket: add functions for unspecified platforms #1070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nit otherwise lgtm
What is pending for merge here ? |
I don't have the merge rights. 🥲 |
@adrianchiris Do you think this can be merged, or any other work is required on this PR ? |
please squash the commits into one |
@aboch AFAIK the squash can be performed during merge, so whoever will be merging this PR, they can squash the commits. |
Please squash the commit and push again. |
f643081
to
bc534ec
Compare
I love Github. Closing PRs just like that, when one resyncs the other branch. |
Why did you close the PR? |
I am not sure why GH closed your PR. Never happened to me before. |
This PR adds socket functions for unspecified (non-Linux) platforms and fixes #1069.