Skip to content

socket: add functions for unspecified platforms #1070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

zajdee
Copy link
Contributor

@zajdee zajdee commented Mar 27, 2025

This PR adds socket functions for unspecified (non-Linux) platforms and fixes #1069.

Copy link
Collaborator

@adrianchiris adrianchiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit otherwise lgtm

@lazysegtree
Copy link
Contributor

What is pending for merge here ?

@zajdee
Copy link
Contributor Author

zajdee commented Jul 19, 2025

I don't have the merge rights. 🥲

@lazysegtree
Copy link
Contributor

lazysegtree commented Jul 20, 2025

@adrianchiris Do you think this can be merged, or any other work is required on this PR ?
cc : @aboch

@aboch
Copy link
Collaborator

aboch commented Jul 20, 2025

please squash the commits into one

@zajdee
Copy link
Contributor Author

zajdee commented Jul 20, 2025

@aboch AFAIK the squash can be performed during merge, so whoever will be merging this PR, they can squash the commits.
Or would you like me to do it and force push the squashed commit into this repo? (That will likely reset the approval.)

@aboch
Copy link
Collaborator

aboch commented Jul 20, 2025

Please squash the commit and push again.
This project does not have the "Rebase and Squash" option enabled.

@zajdee zajdee force-pushed the main branch 2 times, most recently from f643081 to bc534ec Compare July 20, 2025 07:39
@zajdee zajdee closed this Jul 20, 2025
@zajdee
Copy link
Contributor Author

zajdee commented Jul 20, 2025

I love Github. Closing PRs just like that, when one resyncs the other branch.
This is the change, squashed, in a new PR:
#1107

@aboch
Copy link
Collaborator

aboch commented Jul 20, 2025

Why did you close the PR?
All you had to do is to squash your commits in your local git branch, then force push to origin...

@aboch
Copy link
Collaborator

aboch commented Jul 20, 2025

I am not sure why GH closed your PR. Never happened to me before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

undefined socket functions for non-Linux platforms causing issues
4 participants