-
Notifications
You must be signed in to change notification settings - Fork 62
Add CLI options for backend args (like headers and verify) #230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for the contribution. For backend specific arguments, please nest them under --backend_args
and handle any parsing within the backend's __init__
. Please also replace all occurrences of ssl
with cert
or some other protocol neutral term.
Ok thanks for feedback, will look into those changes |
037cd42
to
e816a81
Compare
@sjmonson pushed some updates, looks like workflow needs approval |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks pretty good, just a few design nits. To fix markdown linting run python -m mdformat <files>
a9f92e1
to
d3858ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but commits need signoff
This commit enhances the OpenAIHTTPBackend to allow for more flexible configuration via the `--backend-args` CLI option and environment variables. Key changes include: - Support for passing custom request headers. Headers are merged from the CLI, scenario files, and environment variables, with the CLI taking highest precedence. - Headers can be removed by setting their value to `null` in the `--backend-args` JSON string. - The `verify` flag for disabling SSL certificate verification is now correctly handled. - New documentation for the CLI, configuration, and data formats. - New unit tests for the backend logic and CLI argument parsing. Signed-off-by: Elijah DeLee <[email protected]>
d3858ef
to
85358d0
Compare
This PR adds the ability to configure custom request headers and control SSL certificate verification when running benchmarks.
This provides a way to benchmark targets that require custom authentication, other headers, or use self-signed SSL certificates.