modulesync 10.0.0

.github/workflows/ci.yml

@@ -16,6 +16,9 @@ concurrency:
   group: ${{ github.ref_name }}
   cancel-in-progress: true
 
+permissions:
+  contents: read
+
 jobs:
   puppet:
     name: Puppet

.github/workflows/labeler.yml

@@ -8,6 +8,10 @@ name: "Pull Request Labeler"
 on:
   pull_request_target: {}
 
+permissions:
+  contents: read
+  pull-requests: write
+
 jobs:
   labeler:
     permissions:

.github/workflows/prepare_release.yml

@@ -11,6 +11,10 @@ on:
         description: 'Module version to be released. Must be a valid semver string without leading v. (1.2.3)'
         required: false
 
+permissions:
+  contents: write
+  pull-requests: write
+
 jobs:
   release_prep:
     uses: 'voxpupuli/gha-puppet/.github/workflows/prepare_release.yml@v3'

.github/workflows/release.yml

@@ -10,6 +10,9 @@ on:
     tags:
       - '*'
 
+permissions:
+  contents: write
+
 jobs:
   release:
     name: Release

.msync.yml

@@ -2,4 +2,4 @@
 # Managed by modulesync - DO NOT EDIT
 # https://voxpupuli.org/docs/updating-files-managed-with-modulesync/
 
-modulesync_config_version: '9.5.0'
+modulesync_config_version: '10.0.0'

Gemfile

@@ -4,9 +4,7 @@
 source ENV['GEM_SOURCE'] || 'https://rubygems.org'
 
 group :test do
-  gem 'voxpupuli-test', '~> 9.0',   :require => false
-  gem 'coveralls',                  :require => false
-  gem 'simplecov-console',          :require => false
+  gem 'voxpupuli-test', '~> 11.0',  :require => false
   gem 'puppet_metadata', '~> 5.0',  :require => false
 end
 
@@ -20,13 +18,11 @@ group :system_tests do
 end
 
 group :release do
-  gem 'voxpupuli-release', '~> 3.0',  :require => false
+  gem 'voxpupuli-release', '~> 4.0',  :require => false
 end
 
 gem 'rake', :require => false
-gem 'facter', ENV['FACTER_GEM_VERSION'], :require => false, :groups => [:test]
 
-puppetversion = ENV['PUPPET_GEM_VERSION'] || [">= 7.24", "< 9"]
-gem 'puppet', puppetversion, :require => false, :groups => [:test]
+gem 'openvox', ENV.fetch('OPENVOX_GEM_VERSION', [">= 7", "< 9"]), :require => false, :groups => [:test]
 
 # vim: syntax=ruby

spec/unit/provider/package/pear_spec.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+MY_PATH = 'spec/fixtures/unit/provider/package/pear/'
 require 'spec_helper'
 
 describe Puppet::Type.type(:package).provider(:pear) do
@@ -22,7 +23,7 @@
     it 'returns an array of installed packages' do
       allow(described_class).to receive(:pear).
         with('list', '-a').
-        and_return File.read(my_fixture('list_a'))
+        and_return File.read(File.join(MY_PATH, 'list_a'))
 
       expect(described_class.instances.map(&:properties)).to eq [
         { name: 'Archive_Tar',      vendor: 'pear.php.net', ensure: '1.4.0',  provider: :pear },
@@ -94,7 +95,7 @@
     it 'queries information about one package' do
       allow(described_class).to receive(:pear).
         with('list', '-a').
-        and_return File.read(my_fixture('list_a'))
+        and_return File.read(File.join(MY_PATH, 'list_a'))
 
       resource[:name] = 'pear'
       expect(provider.query).to eq(
@@ -107,7 +108,7 @@
     it 'fetches the latest version available' do
       allow(described_class).to receive(:pear).
         with('remote-info', 'Benchmark').
-        and_return File.read(my_fixture('remote-info_benchmark'))
+        and_return File.read(File.join(MY_PATH, 'remote-info_benchmark'))
 
       resource[:name] = 'Benchmark'
       expect(provider.latest).to eq '1.2.9'

spec/unit/provider/package/pecl_spec.rb

@@ -23,7 +23,7 @@
     it 'returns pecl installed packages via pear' do
       allow(parent_class).to receive(:pear).
         with('list', '-a').
-        and_return File.read(fixtures('unit/provider/package/pear/list_a'))
+        and_return File.read(File.join('spec', 'fixtures', 'unit/provider/package/pear/list_a'))
 
       expect(described_class.instances.map(&:properties)).to eq [
         { ensure: '1.13.5', name: 'zip', vendor: 'pecl.php.net', provider: :pecl }
@@ -42,7 +42,7 @@
     it 'queries pecl package info via pear' do
       allow(parent_class).to receive(:pear).
         with('list', '-a').
-        and_return File.read(fixtures('unit/provider/package/pear/list_a'))
+        and_return File.read(File.join('spec', 'fixtures', 'unit/provider/package/pear/list_a'))
 
       resource[:name] = 'zip'
       expect(provider.query).to eq(ensure: '1.13.5', name: 'zip', vendor: 'pecl.php.net', provider: :pecl)
@@ -53,7 +53,7 @@
     it 'fetches the latest version available via pear' do
       allow(parent_class).to receive(:pear).
         with('remote-info', 'pecl.php.net/zip').
-        and_return File.read(fixtures('unit/provider/package/pear/remote-info_zip'))
+        and_return File.read(File.join('spec', 'fixtures', 'unit/provider/package/pear/remote-info_zip'))
 
       resource[:name] = 'zip'
       expect(provider.latest).to eq '1.13.5'

types/duration.pp

@@ -3,4 +3,3 @@
   Integer[0],
   Pattern[/^\d+[smhd]?$/]
 ]
-