[WIP] Az.Ssh #2
[WIP] Az.Ssh #2
Conversation
| //As Compute module must not reference to storage SDK, the types of parameters and return values of | ||
| //public APIs within this project should not expose any types defined in storage SDK. | ||
|
|
||
| public class ComputeClient |
There was a problem hiding this comment.
Usually, editors are set to convert tab characters into spaces. Not sure if that is true for Az cmdlets.
| public class ComputeClient | |
| public class ComputeClient |
| # PowerShellHostVersion = '' | ||
|
|
||
| # Minimum version of Microsoft .NET Framework required by this module. This prerequisite is valid for the PowerShell Desktop edition only. | ||
| DotNetFrameworkVersion = '4.7.2' |
There was a problem hiding this comment.
We normally target 4.6.1 for WindowsPowerShell 5.1 compatibility.
There was a problem hiding this comment.
I will confirm with Azure PowerShell if that is the case for their modules as well. I set it to 4.7.2 because other Az PowerShell modules all do the same.
|
|
||
| namespace Microsoft.Azure.PowerShell.Cmdlets.Ssh.Common | ||
| { | ||
| class SshResourceIdCompleterAttribute : ArgumentCompleterAttribute |
There was a problem hiding this comment.
In PowerShell code base, we are always explicit about type accessiblity.
| class SshResourceIdCompleterAttribute : ArgumentCompleterAttribute | |
| private class SshResourceIdCompleterAttribute : ArgumentCompleterAttribute |
There was a problem hiding this comment.
When I do this change I get an error:
"Elements defined in a namespace cannot be explicitly declared as private, protected, protected internal, or private protected."
There was a problem hiding this comment.
Sorry, I guess this would be internal. I assume it is not a type intended for public use?
| DefaultParameterSetName = InteractiveParameterSet)] | ||
| [OutputType(typeof(bool))] | ||
| [Alias("Enter-AzArcServer")] | ||
| public class EnterAzVMCommand : SshBaseCmdlet |
There was a problem hiding this comment.
| public class EnterAzVMCommand : SshBaseCmdlet | |
| public sealed class EnterAzVMCommand : SshBaseCmdlet |
| [Cmdlet("Export", | ||
| ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "SshConfig")] | ||
| [OutputType(typeof(PSSshConfigEntry))] | ||
| public class ExportAzSshConfig : SshBaseCmdlet |
There was a problem hiding this comment.
| public class ExportAzSshConfig : SshBaseCmdlet | |
| public sealed class ExportAzSshConfig : SshBaseCmdlet |
…d an Azure Resource Id Parser
Description
Checklist
CONTRIBUTING.mdand reviewed the following information:generationbranch.ChangeLog.mdfile(s) appropriatelyChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader in the past tense. Add changelog in description section if PR goes intogenerationbranch.ChangeLog.mdif no new release is required, such as fixing test case only.