Skip to content

chore(build): replace node:fs repeated import #13467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025
Merged

Conversation

xjh22222228
Copy link
Contributor

@xjh22222228 xjh22222228 commented Jun 12, 2025

The 19th line has already imported fs, remove 21 duplicate imports.

Summary by CodeRabbit

  • Refactor
    • Updated file system operations to consistently use the fs namespace. No changes to functionality or user experience.

Copy link

coderabbitai bot commented Jun 12, 2025

Walkthrough

The update standardizes file system function usage in the build script by replacing direct imports of existsSync and readFileSync with calls to these methods via the fs namespace. No logic, error handling, or control flow is changed; only the import style is modified for consistency.

Changes

File(s) Change Summary
scripts/build.js Updated to use fs.existsSync and fs.readFileSync instead of direct imports of these functions from 'node:fs'.

Poem

In the warren where scripts are spun,
A tidy change has just begun.
No more direct calls—just fs in sight,
Making code consistent, clean, and right.
The build hops forward, neat and keen,
With every byte now calm and serene! 🐇✨

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
scripts/build.js (1)

165-165: Use path.join for constructing file paths
Consider replacing string interpolation with path.join(pkgDir, 'package.json') for better cross-platform compatibility:

- fs.readFileSync(`${pkgDir}/package.json`, 'utf-8')
+ fs.readFileSync(path.join(pkgDir, 'package.json'), 'utf-8')
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cdffaf6 and 46e083e.

📒 Files selected for processing (1)
  • scripts/build.js (2 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
scripts/build.js (4)
rollup.config.js (1)
  • pkg (45-45)
scripts/release.js (2)
  • pkg (81-83)
  • pkg (457-457)
scripts/dev.js (2)
  • pkg (63-63)
  • targets (43-43)
scripts/utils.js (3)
  • pkg (18-18)
  • targets (9-24)
  • targets (9-24)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules
  • GitHub Check: Header rules
  • GitHub Check: Pages changed
🔇 Additional comments (2)
scripts/build.js (2)

173-173: Unified fs.existsSync usage
Direct import of existsSync has been replaced with fs.existsSync, aligning with the single fs import and eliminating redundant imports.


236-236: Consistent fs.existsSync in checkFileSize
Switched to fs.existsSync instead of a direct import; this change maintains consistency in module usage.

Copy link

pkg-pr-new bot commented Jun 12, 2025

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13467

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13467

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13467

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13467

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13467

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13467

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13467

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13467

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13467

vue

npm i https://pkg.pr.new/vue@13467

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13467

commit: 46e083e

Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 101 kB 38.4 kB 34.6 kB
vue.global.prod.js 159 kB 58.5 kB 52.2 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.7 kB 18.2 kB 16.7 kB
createApp 54.6 kB 21.3 kB 19.4 kB
createSSRApp 58.9 kB 23 kB 21 kB
defineCustomElement 59.6 kB 22.9 kB 20.9 kB
overall 68.7 kB 26.4 kB 24.1 kB

@KazariEX KazariEX added the 🧹 p1-chore Priority 1: this doesn't change code behavior. label Jun 12, 2025
@edison1105 edison1105 merged commit 6c68421 into vuejs:main Jun 13, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 p1-chore Priority 1: this doesn't change code behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants