fix(reactivity): optimize size retrieval in createInstrumentations

[yangdan8]

Summary by CodeRabbit

• Refactor
  • Streamlined how sizes are read for reactive Map/Set collections, reducing overhead for size checks.
  • Users may notice marginal performance improvements when viewing or computing sizes of these collections; no behavioral changes are expected.

[coderabbitai]

Walkthrough

Adjusted Map/Set size accessor in collection instrumentations to read size via direct property access (target.size) instead of Reflect.get. Existing retrieval of raw target, iterate tracking with ITERATE_KEY when not readonly, and overall control flow remain unchanged. No public API or exports altered.

Changes

Cohort / File(s)	Summary
Reactivity collection size accessor packages/reactivity/src/collectionHandlers.ts	Replace Reflect.get for size accessor with direct property access (target.size); maintain existing RAW unwrapping and ITERATE tracking; no behavior or API surface changes declared.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

I counted keys with whiskers twitch—
a hop from Reflect to size, a switch.
No paths were changed, no loops were bent,
just cleaner steps where bytes are spent.
Thump-thump! I nibble code so nice—
one tiny change, precise as rice.

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these settings in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between c875019 and 7bde003.

📒 Files selected for processing (1)

• packages/reactivity/src/collectionHandlers.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: Redirect rules
• GitHub Check: Header rules
• GitHub Check: Pages changed

🔇 Additional comments (1)

packages/reactivity/src/collectionHandlers.ts (1)

125-129: LGTM: direct property access preserves semantics and avoids Reflect overhead

Accessing target.size here is semantically equivalent to Reflect.get(target, 'size', target) for Map/Set and is a small win on hot paths. Tracking with ITERATE_KEY still occurs when not readonly, so reactivity behavior is unchanged.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.