-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
fix(runtime-vapor): more accurate fallthrough attr support #13972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: minor
Are you sure you want to change the base?
fix(runtime-vapor): more accurate fallthrough attr support #13972
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Size ReportBundles
Usages
|
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/compiler-vapor
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/runtime-vapor
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
The following scenarios need to be fixed |
@edison1105 updated and edited the PR title! |
type: IRNodeTypes.SET_DYNAMIC_PROPS, | ||
element: context.reference(), | ||
props: dynamicArgs, | ||
root: singleRoot, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unused so I removed it; it gets sent as an argument to setDynamicProps
but the param was removed in this commit
type: IRNodeTypes.SET_PROP, | ||
element: context.reference(), | ||
prop, | ||
root: singleRoot, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also removed due to being unused
Fix fallthrough attributes in Vapor mode when target component has comments in its template root level
Example
Comp.vue
App.vue