-
-
Notifications
You must be signed in to change notification settings - Fork 7k
feat(VFileUpload, VFileInput): strict-accept
prop
#21576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
J-Sek
wants to merge
14
commits into
dev
Choose a base branch
from
fix/file-drop-accept
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: John Leider <[email protected]>
Co-authored-by: John Leider <[email protected]>
accept
I am 50/50 on renaming the prop to something like |
I like this idea. |
accept
strict-accept
prop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Usually,
accept
is considered a "mild suggestion" by the browser, and is misunderstood by developers as a way to reliably filter files on the frontendaccept
and it is a default behavior (not the fault of our implementation)webkitdirectory
, it makes the native file picker unusableThis PR changes default behavior to make
accept
strict. While doing so, it may introduce UX degradation - user might be think the page is broken, becauseaccept
rules are not obvious or he does not know whether valid files are contained within a folder he drops. Newrejected
event lets developer handle it by flashing warning with Snackbar or showing small dismissable alert next to the field.Outlined changes:
strict-accept
for drag&drop and regular selectionaccept
to the underlying input whenwebkitdirectory
is presentTBD: it is quite easy to make a typo in
accept
value and I am considering prop validation. Dropped it last minute, because it would be relatively larger in comparison to existing prop validators. There are however only 11 groups, so maybe we can revisit this enhancement (source »[...document.querySelectorAll('h2')].map(x => x.innerText)
).resolves #21150
Markup: