-
-
Notifications
You must be signed in to change notification settings - Fork 7k
feat(VDatePicker): align control variants with MD3 #21589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
6abd849
to
f4ec116
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Done. All buttons are rounded now. Playground (in the description) is updated and includes more fun examples of I wonder if the documentation examples should include them all or just the first one. BTW. It opens a way to deliver dual calendar picker with less hacks.. (my last attempt) although there is still a challenge to have single selection model. |
d97d1a3
to
6984f13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. The only changes missing completely would be updating the md1/2/3 blueprints so that the picker is inline with that version of md.
packages/vuetify/src/components/VDatePicker/VDatePickerControls.sass
Outdated
Show resolved
Hide resolved
packages/vuetify/src/components/VDatePicker/VDatePickerControls.sass
Outdated
Show resolved
Hide resolved
packages/vuetify/src/components/VDatePicker/VDatePickerControls.sass
Outdated
Show resolved
Hide resolved
@johnleider, is there anything except this simple change? (and a decision between those options) |
49fbedf
to
2949ec5
Compare
2949ec5
to
f829383
Compare
Not from me, that's all I had. |
Description
control-variant
withdocked
andmodal
optionsno-month-picker
to merge left buttons into one (very common across other component frameworks, notably MUI)controls
slot so developers can override controls if they have more specific needsPreview:
Markup:
Kitchen sink