feat[venom]: stack order analysis #4646
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4646 +/- ##
==========================================
+ Coverage 92.80% 92.86% +0.06%
==========================================
Files 131 132 +1
Lines 18947 19132 +185
Branches 3289 3334 +45
==========================================
+ Hits 17583 17767 +184
Misses 933 933
- Partials 431 432 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vyper/venom/passes/dft.py
Outdated
|
|
||
| while len(worklist) > 0: | ||
| bb = worklist.popleft() | ||
| stack_order = self.stack_order.handle_bbs(list(self.cfg.cfg_out(bb))) |
There was a problem hiding this comment.
does the liveness need to be recomputed for these bbs?
| @@ -0,0 +1,345 @@ | |||
| import pytest | |||
Check notice
Code scanning / CodeQL
Unused import Note test
Comment on lines
+486
to
+488
| #for op in reversed(liv): | ||
| #if op not in target_stack: | ||
| #target_stack.insert(0, op) |
Check notice
Code scanning / CodeQL
Commented-out code Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
inter bb stack analysis
How I did it
used the intra bb analysis (dft) as a base for the inter bb by propagating the information between the basic blocks
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture