Skip to content

fix[tool]: remove duplicate quotes in subgraph labels which created a syntax error in the dot output #4672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

crebsy
Copy link
Contributor

@crebsy crebsy commented May 30, 2025

What I did

The subgraph labels of the IR contain duplicate double quotes "" for the internal nodes which create a syntax error when parsing the generated output with graphviz. As a fix, I removed the duplicates so that the output only contains " now and can be used with graphviz again.

How I did it

Changed the string interpolation of the subgraph label

How to verify it

Run tests or manually pipe the compiler output cfg_runtime format into dot:

$ vyper -f cfg_runtime --venom test.vy | dot 

Commit message

fix[tool]: remove duplicate quotes in subgraph labels which created a syntax error in the dot output

Description for the changelog

Remove duplicate quotes in subgraph labels which created a syntax error in the dot output

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

Copy link

codecov bot commented May 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.94%. Comparing base (76d6a0f) to head (102cbaf).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4672      +/-   ##
==========================================
+ Coverage   92.92%   92.94%   +0.01%     
==========================================
  Files         131      131              
  Lines       18991    18991              
  Branches     3295     3295              
==========================================
+ Hits        17648    17651       +3     
  Misses        905      905              
+ Partials      438      435       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant