Skip to content

Add guidance on how to handle multiple presentation request entries #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

MasterKale
Copy link

@MasterKale MasterKale commented May 28, 2025

This PR adds initial text on A) how user agents MUST handle the presence of multiple presentation requests in options.digital.requests, and B) how verifiers SHOULD populate options.digital.requests to handle getting back a corresponding presentation response.

Closes #220.

The following tasks have been completed:

  • Modified Web platform tests (link)

Implementation commitment:

  • WebKit (link to issue)
  • Chromium (link to issue)
  • Gecko (link to issue)

Documentation and checks

  • Affects privacy
  • Affects security
  • Pinged MDN
  • Updated Explainer
  • Updated digitalcredentials.dev

Preview | Diff

@MasterKale MasterKale requested a review from a team as a code owner May 28, 2025 21:48
@MasterKale MasterKale added the agenda+ Add to the weekly agenda label May 29, 2025
Comment on lines +493 to +495
[=user agents=] MUST only return one
[=digital credential/presentation responses | presentation response=] for one
of these requests.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[=user agents=] MUST only return one
[=digital credential/presentation responses | presentation response=] for one
of these requests.
[=user agents=] MUST return a maximum of one
[=digital credential/presentation responses | presentation response=] for each
of these requests.

Comment on lines +496 to +497
Multiple credentials MAY be present in this one response depending on the capabilities
of the corresponding [=digital credential/exchange protocol=].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs further refinement. I'm trying to capture the concept before getting the language just right. There will also need to be some language about what happens when a response that contains credentials A, B, and C is sent after receiving individual requests for credentials A, B, C, D and E, and then a new request for credential B is received. Does the first response cause the new request for B to be ignored? Or might a new response containing B, D, and E be sent? Or something else?

Suggested change
Multiple credentials MAY be present in this one response depending on the capabilities
of the corresponding [=digital credential/exchange protocol=].
Multiple credentials MAY be present in one such response depending on the capabilities
of the corresponding [=digital credential/exchange protocol=].
Each credential SHOULD be present in only one such response, such that a response
containing multiple credentials is considered to be a response to all individual
requests for one of the credentials it contains.

@wseltzer
Copy link
Contributor

Discussed 11 June minutes

@wseltzer wseltzer removed the agenda+ Add to the weekly agenda label Jun 12, 2025
of these requests.
Multiple credentials MAY be present in this one response depending on the capabilities
of the corresponding [=digital credential/exchange protocol=].
<aside class="note">
Copy link
Collaborator

@marcoscaceres marcoscaceres Jun 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notes shouldn't include RFC2119 keywords (i.e., get rid of the SHOULD).

I don't think this even makes sense, to be honest. How they are presented is up to the user agent, not up to verifier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for multiple requests in a get call
4 participants