Skip to content

Use "Strip URL" from the Reporting API #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yoavweiss
Copy link
Contributor

@yoavweiss yoavweiss commented Jun 13, 2025

We recently added an exported strip URL for use in reporting to the Reporting API. This PR makes use of that, and drops the CSP-only algorithm


Preview | Diff

@yoavweiss yoavweiss requested review from mikewest and antosart June 13, 2025 07:12
@annevk
Copy link
Member

annevk commented Jun 13, 2025

While this is identical, the algorithm is wrong. This would have all URLs end with #. You need to set fragment to null (or use the "exclude fragment" serialization option).

@yoavweiss
Copy link
Contributor Author

While this is identical, the algorithm is wrong. This would have all URLs end with #. You need to set fragment to null (or use the "exclude fragment" serialization option).

Thanks! I'll fix up the reporting algo

@yoavweiss
Copy link
Contributor Author

@annevk Filed w3c/reporting#285 (can't add you as a reviewer for some reason..)

@evilpie
Copy link
Contributor

evilpie commented Jun 13, 2025

Please hold off on merging this. I am going to report some significant differences between the specifications and the implementations shortly.

@evilpie
Copy link
Contributor

evilpie commented Jun 13, 2025

#735

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants