Allow for specifying schema in "proxy" #1922
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadym-chromium
force-pushed
the
sadym/proxy
branch
from
8b7b4d2 to
5b447f9
Compare
sadym-chromium
changed the title
sadym-chromium
changed the title
whimboo
requested changes
Sep 2, 2025
| </tr> | ||
|
|
||
| <tr> | ||
| <td><code>socksVersion</code> |
There was a problem hiding this comment.
Is there a reason why you removed the socksVersion field? I thought that for socks proxies it is a mandatory field. Also if clients specify this field we would run into a backward incompatible change.
| defined as being a valid <a>host</a>, optionally followed by a colon | ||
| and a valid <a>port</a>. The <a>host</a> may | ||
| <p>A <dfn>proxy url</dfn> is a valid <a>host</a>, optionally followed by a colon | ||
| and a valid <a>port</a>, and optionally prefixed by a <a>proxy schema</a> |
There was a problem hiding this comment.
Personally I would move the schema part before port so that the order is equal to how parts of an URL are specified.
| undefined. | ||
|
|
||
| <p>A <dfn>proxy schema</dfn> is defined as being one of the following strings: | ||
| "<code>http</code>", "<code>https</code>", "<code>socks4</code>", |
There was a problem hiding this comment.
Neither socks4 nor socks5 is a valid schema as supported by Firefox. For socks proxy there is usually no schema at all when specifying the host. Does Chrome support that? Also note the other comment above regarding the backward incompatible change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #1920.
Currently, WebDriver capabilities allow for configuring proxy by protocol. Meaning the protocol traffic can be proxied via the same protocol proxy.
Chromium can proxy traffic via different proxy protocols, and can configure which proxy to use for which protocol. In Chromium, the possible proxy schemas are
http,https,socks4,socks5. Also user can configure separately proxy forHTTP,HTTPSand all other requests (SOCKS).In order to allow for such configurations, we propose the following:
http,https,socks4,socks5) in the proxy url.socksin favor ofotherproxy configuration.Preview | Diff