Skalman set keys proof with rt proof of possession function #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…6` (paritytech#9705) The value is just cast to `U256` here, without applying the actual conversion factor (`NativeToEthRatio`). There are some tests that apply the same easy conversion via `Into`, without applying the conversion factor. Those tests still succeed, but you might want to go through those usages to not confuse people reading the code. @athei @pgherveou
Removes collator-related code in cumulus, which has been deprecated for a long time. Removes an old test, which was adapted in paritytech/cumulus#480 and duplicated by https://github.com/paritytech/polkadot-sdk/blob/acac0127168dac1d603e4d996cb210ceeddeb5de/substrate/client/block-builder/src/lib.rs#L389-L415 ## PoV Recovery Test Updates Updates the PoV recovery test (`cumulus/zombienet/zombienet-sdk/tests/zombie_ci/pov_recovery.rs`) to use a more realistic consensus mechanism: ### Changes Made - **Removed**: `--use-null-consensus` flag from test configuration ### Rationale **Previous behavior** (with null consensus): - Nodes operated without real block production - PoV recovery mechanisms triggered more frequently - Created artificial test conditions that don't reflect production scenarios **New behavior** (with actual consensus): - Nodes produce blocks normally but don't announce them to peers - PoV recovery occurs at a more realistic frequency - Better simulates real-world network conditions where blocks may be missed ### Impact This change makes the test **more representative** of actual network conditions while maintaining the core functionality being tested. ## Follow-up Remove the following lines: https://github.com/paritytech/polkadot-sdk/blob/4acb964059a218be9bac954b4e3803b78b5526bf/cumulus/pallets/parachain-system/src/lib.rs#L993-L994 ## Review notes I recommend enabling `Hide whitespace` option when reviewing the changes: <img width="300" alt="image" src="https://github.com/user-attachments/assets/41f137af-c0b9-435e-af1e-84e51cbdfa23" />
…ritytech#9731) resolves paritytech#9730 --------- Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Added trace logging for each instruction to evm::run function. solves paritytech#9575 --------- Signed-off-by: xermicus <[email protected]> Signed-off-by: Cyrill Leutwiler <[email protected]> Co-authored-by: pgherveou <[email protected]> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Robert van Eerdewijk <[email protected]> Co-authored-by: xermicus <[email protected]> Co-authored-by: Alexander Theißen <[email protected]> Co-authored-by: Cyrill Leutwiler <[email protected]>
Fix CodeInfo owner, it should always be set to the origin of the transaction --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…tech#9747) - Add early return in do_try_state when pallet is uninitialized - Add test for empty state validation Followup of paritytech#9721 . Once backported to `2507` and crate is published, should unlock polkadot-fellows/runtimes#904 --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…#9745) Related to paritytech#9641 Avoid double counting PoV size when enqueing XCMP message --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Andrii <[email protected]>
Tracing fixes: - collect_trace take `self` instead of `&mut self`, to avoid reusing the tracer state when tracing multiple transactions in a block. - Fix issues related to call traces and the onlyTopCall config option Fix paritytech/contract-issues#156 --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ech#9742) Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…aritytech#9701) This will enable more flexible usage of the revive RPC as a library. Needed so that we can reuse it with an in-memory RPC client for anvil-polkadot: paritytech/foundry-polkadot#238
…tytech#9517) Part of closing paritytech#8572. Migrates: * `own_code_hash` * `caller_is_origin` * `caller_is_root` * `weight_left` * `minimum_balance` There are some minor other fixes in there (removing leftovers from deprecating chain extensions, stabilizing `block_hash` in overlooked crates, etc.). cc @athei @pgherveou --------- Co-authored-by: Alexander Theißen <[email protected]>
Currently, the Aura authorities tracker uses the block pre-hash to import the authorities, but the post-hash to fetch them. That results in block verification failures. A scenario to reproduce the bug is as follows: * Start a parachain with a single-collator fixed-authority Aura; * Upgrade the parachain runtime to include `session` and `collator-selection` pallets; * Register the collator keys as session keys, then add the collator to invulnerables; * Start a second collator, rotate its keys, register them as session keys, and add the second collator to invulnerables; * When the second collator is trying to import the block where it's enacted as the second Aura authority, it fails the block verification and does not import or produce any blocks anymore. This PR changes the behavior to importing the authorities using the block post-hash, which fixes the bug. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
PR switches test-linux-stable to new runners. cc paritytech/devops#3875
This removes the `CheckInherents` logic from `register_validate_block`, instead the `ConsensusHook` should be used to verify certain data. Besides that it also changes the how `validate_block` verifies the `ValidationData` passed by the collator. Instead of extracting the `ValidationData` before executing the block, the validation data is now checked as part of the pallet logic. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This PR makes it easier for first-time builders to just copy-and-paste and fix typos. Relates to paritytech/polkadot-sdk-minimal-template#25
fix <paritytech#9769> --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Fix `pallet_election_provider_multi_block_signed::register_eject` benchmark failing on KAHM due to `funded_account()` function not providing enough balance to cover the required deposits. See for example [here](https://github.com/polkadot-fellows/runtimes/actions/runs/17765363309/job/50487393309?pr=856). The fix ensures that benchmark accounts have sufficient funds to cover the worst-case deposit scenario (registration + all pages submission) --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ech#9949) # Description This is an amendment to paritytech#1739 to use the newly developed ProofOfPossessionGenerator/Verifier API instead of using `sign` and `verify` in order to generate and validate key ownership proofs. This is necessary because BLS keys need more complicated proofs which are not possible to be produced using `sign`. From the specification point of view, this PR only adds a context prefix of "POP_" to the ownership statement, otherwise its behaviour is identical to paritytech#1739.
…polkadot-sdk into skalman--set-keys-proof-with-rt-proof-of-possession-function
…paritytech#10002) To solve the CI Build errors in the implementation of `generate_session_key for the following runtimes: - cumulus/parachains/runtimes/testing/yet-another-parachain - cumulus/polkadot-omni-node/lib/src/fake_runtime_api - substrate/frame/revive/dev-node/runtime
…ttps://github.com/paritytech/polkadot-sdk into skalman--set-keys-proof-with-rt-proof-of-possession-function
ownership proof
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✄ -----------------------------------------------------------------------------
Thank you for your Pull Request! 🙏 Please make sure it follows the contribution guidelines outlined in this
document and fill out the
sections below. Once you're ready to submit your PR for review, please delete this section and leave only the text under
the "Description" heading.
Description
A concise description of what your PR is doing, and what potential issue it is solving. Use Github semantic
linking
to link the PR to an issue that must be closed once this is merged.
Integration
In depth notes about how this PR should be integrated by downstream projects. This part is
mandatory, and should be reviewed by reviewers, if the PR does NOT have the
R0-no-crate-publish-requiredlabel. In case of aR0-no-crate-publish-required, it can beignored.
Review Notes
In depth notes about the implementation details of your PR. This should be the main guide for reviewers to
understand your approach and effectively review it. If too long, use
<details>.Imagine that someone who is depending on the old code wants to integrate your new code and the only information that
they get is this section. It helps to include example usage and default value here, with a
diffcode-block to showpossibly integration.
Include your leftover TODOs, if any, here.
Checklist
Trequired)You can remove the "Checklist" section once all have been checked. Thank you for your contribution!
✄ -----------------------------------------------------------------------------