Added the two new types any_pointer and any_array #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As requested in the issue wc-duck#145
Tisten
commented
Oct 27, 2022
| void* instance, size_t instance_size, | ||
| const unsigned char* packed_instance, size_t packed_instance_size, | ||
| size_t* consumed ) | ||
| void* instance, size_t instance_size, |
There was a problem hiding this comment.
This PR contains some "space to tab" conversions to minimize the "strange indent here" feedback.
There was a problem hiding this comment.
I'll try to get to fixing a clang-format file :)
Tisten
commented
Oct 27, 2022
| @@ -177,11 +177,11 @@ static void dl_internal_store_string( const uint8_t* instance, CDLBinStoreContex | |||
| dl_binary_writer_write( &store_ctx->writer, &offset, sizeof(uintptr_t) ); | |||
| } | |||
|
|
|||
| static dl_error_t dl_internal_instance_store( dl_ctx_t dl_ctx, const dl_type_desc* type, uint8_t* instance, CDLBinStoreContext* store_ctx ); | |||
| static dl_error_t dl_internal_instance_store( dl_ctx_t dl_ctx, const dl_type_desc* type, const uint8_t* instance, CDLBinStoreContext* store_ctx ); | |||
There was a problem hiding this comment.
The "store" functions now treat the data as const
Tisten
commented
Oct 27, 2022
src/dl.cpp
Outdated
| return err; | ||
| dl_binary_writer_seek_set( &store_ctx->writer, sub_pos ); | ||
|
|
||
| // use when fast_loading is merged |
There was a problem hiding this comment.
This code was written to work with fast pointer patching, but since that PR hasn't been merged I've re-written this PR to work without it.
Tisten
commented
Oct 27, 2022
src/dl_typelib_write_c_header.cpp
Outdated
| " // ... DL_DECLARE_ANY ...\n" | ||
| " typedef uint32_t dl_typeid_t;\n" | ||
| "\n" | ||
| " struct dl_anyptr {\n" |
There was a problem hiding this comment.
This is the C/C++ type for anyptr
Tisten
commented
Oct 27, 2022
wc-duck
reviewed
Nov 2, 2022
| { | ||
| dl_type_atom_t atom_type = member->AtomType(); | ||
| dl_type_storage_t storage_type = member->StorageType(); | ||
|
|
||
| if (storage_type == DL_TYPE_STORAGE_ANYARRAY) | ||
| atom_type = DL_TYPE_ATOM_ARRAY; // To avoid code duplification and simplify implementation |
There was a problem hiding this comment.
Would you prefer the code duplification here?
Tisten
changed the title
The new style is
"MyAnyPointer" : {
"type": "the_type",
"data": "ptr_88"
},
"MyAnyArray" : {
"type": "the_type",
"data": [ { "member": "value" } ]
}
# Conflicts: # src/dl.cpp # src/dl_txt_pack.cpp # src/dl_typelib_write_c_header.cpp # tests/dl_tests_error.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in the issue #145