Fix setting display state when light detection is turned on

[SapuSeven]

When light detection is turned on, it controls the display status.
If trying to set the display status while light detection is on, the API responds with error "11017000 (BYPASS_NOT_SUPPORTED)".

As a fix, the toggle_display method now checks the light detection status and turns it off if necessary before setting the display status.

Testing (on Levoit Vital 100S) has shown that there is a small delay when disabling light detection before the display can be set - I added a 1 second delay in that case which was enough time in my case.

---

I included another small change regarding the login methods that I missed in #348 which fixes a cross-region error being thrown even though login was successful.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[cdnninja]

This solves a login failure that I think is worthy of a release so we can continue testing with users.

[webdjoe]

I'm thinking that it should be avoided to set two states in a single method. The toggle_display method should only set the display and return False with a log message if it is unable to set the display status due to light detection. I believe that it should be up to the user to turn off light detection before setting the display. Ideally I would rather check if light detection in enabled and return false without making the API call. Does this cause an issue with the HA component?

[SapuSeven]

Good point. It does cause an issue with HA since it doesn't have an entity for light detection, so when it's enabled the HA display control just doesn't work.
But I agree that this kind of logic doesn't really belong in the library - I'll modify the PR.

[webdjoe]

You could always look at the last_response attribute and log an error based on that code in the integration

[cdnninja]

That general issue is something that has been on my mind. Right now if an action fails HA does display it but doesn't provide the reason to the user. Ideally in HA when we throw the exception we would pass the text result. Sounds like we can do that in HA based on last response text.

[SapuSeven]

I reverted the automatic call to toggle_light_detection and instead the toggle_display will return False with an error message in the logs in that case.

[webdjoe]

Thank you!