Skip to content

[ENGAGE-4034] Add external history link to contact info and update translations #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mateuseduardomedeiros
Copy link
Collaborator

Description

Type of Change

    • Bugfix
    • Feature
    • Code style update (formatting, local variables)
    • Refactoring (no functional changes, no api changes)
    • Tests
    • Other

Motivation and Context

Display an external link to old chat histories outside the platform

Summary of Changes

  • Add external history link

Design Files

Demonstration

image

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Inconsistent Property Access Breaks Link Display

The external history link's v-if condition closedRoom?.external_history_link is inconsistent with the component's established pattern of accessing properties via (closedRoom || room). This prevents the link from displaying when the room prop contains an external_history_link but closedRoom is undefined or empty. The condition should be (closedRoom || room)?.external_history_link.

src/components/chats/ContactInfo/index.vue#L53-L54

<a
v-if="closedRoom?.external_history_link"

Fix in Cursor


Was this report helpful? Give feedback by reacting with 👍 or 👎

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 66.15%. Comparing base (7c26eb7) to head (e5d085c).

Files with missing lines Patch % Lines
src/components/chats/ContactInfo/index.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #660   +/-   ##
=======================================
  Coverage   66.14%   66.15%           
=======================================
  Files         194      194           
  Lines        7258     7259    +1     
  Branches     1677     1678    +1     
=======================================
+ Hits         4801     4802    +1     
  Misses       2457     2457           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants