Displaying the cookie consent view after DOMContentLoaded #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #47 and #63.
Added
DOMContentLoadedto ensure the cookie consent view is shown after the DOM is fully loaded.I noticed the merged pull request #86 which ensures
window.LaravelCookieConsentis initialized afterDOMContentLoaded. With this said, it is still possible for the cookie consent box to be shown beforewindow.LaravelCookieConsentis initialized, which would result in undefined errors when clicking on the cookie consent buttons. This PR solves this scenario.