Skip to content

Add a few more type annotations to Parser::Builders::Default #1078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add a few more type annotations to Parser::Builders::Default #1078

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/parser/builders/default.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2295,10 +2295,14 @@ def collapse_string_parts?(parts)
[:str, :dstr].include?(parts.first.type)
end

# @param [::Parser::AST::Node] token
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for a late review but I think this signature is wrong. This method takes a token, not a node. Same for the method below.

# @return [String]
def value(token)
token[0]
end

# @param [::Parser::AST::Node] token
# @return [String]
def string_value(token)
unless token[0].valid_encoding?
diagnostic(:error, :invalid_encoding, nil, token[1])
Expand Down
Loading