Skip to content

Test Python 3.10 #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 4 additions & 19 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,10 @@ jobs:
matrix:
os:
- ubuntu-20.04
python-version: [ 3.5.4, 3.5.10, 3.6.7, 3.6.10, 3.6.14, 3.7.5, 3.7.11, 3.8.0, 3.8.5, 3.9.0, 3.9.6]
python-version:
- "3.8"
- "3.9"
- "3.10"

steps:
- uses: actions/checkout@v3
Expand All @@ -34,21 +37,3 @@ jobs:

- name: Run tests
run: coverage run --source=vwo setup.py test

- name: Upload coverage to Codecov
uses: codecov/codecov-action@v3
env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
with:
fail_ci_if_error: true

- name: Notification
if: always()
id: slack
uses: wingify/[email protected]
with:
channel-id: 'fs-review-team'
slack-message: "<!here> Test on *Python-${{ matrix.python-version }}* and *${{ matrix.os }}* got *${{job.status}}* ${{job.status == 'success' && ':heavy_check_mark:' || ':x:'}} \nCommit: `${{github.event.head_commit.message}}`. \nCheck the latest build: https://github.com/wingify/vwo-python-sdk/actions"
color: "${{job.status == 'success' && '#00FF00' || '#FF0000'}}"
env:
SLACK_BOT_TOKEN: ${{ secrets.SLACK_NOTIFICATIONS_BOT_TOKEN }}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removals here are so that I could run this on my fork: bhrutledge#1

4 changes: 2 additions & 2 deletions requirements.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
pyrsistent>=0.16.1; python_version>="3.4"
jsonschema>=3.0.1,<4.0
jsonschema>=4.1.2,<4.18
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional testing related to #5

mmh3==2.5.1
requests[security]>=2.9.1
redis==5.0.1
redis==5.0.1
5 changes: 4 additions & 1 deletion tests/logger/test_VWOLogger.py
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,10 @@ def test_getInstance_log_level_passed(self):
def test_getInstance_logging_logger_passed(self):
logger = VWOLogger.getInstance(logger=logging.getLogger())
self.assertIsInstance(logger, VWOLogger.VWOLogger)
self.assertIs(logger.logger.level, 30) # Default log level of logging.Logger is INFO, ie 30
if sys.version_info >= (3, 10):
self.assertIs(logger.logger.level, 20) # In Python >=3.10, the default log level is 20 (INFO)
else:
self.assertIs(logger.logger.level, 30) # In Python <3.10, the default log level is 30 (WARNING)

def test_getInstance_custom_logger_passed(self):
class Logger:
Expand Down