Skip to content

Conversation

trueberryless
Copy link
Contributor

@trueberryless trueberryless commented Oct 5, 2025

Description

Translate all pages of section 5 of the Astro Tutorial into German.
Merging into de/tutorial and when all tutorial pages are translated, merging this branch into main 👍

Note

Hacktoberfest participation please!

Related PRs

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Oct 5, 2025
@astrobot-houston
Copy link
Contributor

astrobot-houston commented Oct 5, 2025

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
de/tutorial/5-astro-api/1.mdx Localization added, will be marked as complete.
de/tutorial/5-astro-api/2.mdx Localization added, will be marked as complete.
de/tutorial/5-astro-api/3.mdx Localization added, will be marked as complete.
de/tutorial/5-astro-api/4.mdx Localization added, will be marked as complete.
de/tutorial/5-astro-api/index.mdx Localization added, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@trueberryless
Copy link
Contributor Author

In this PR the German tutorial is bugged. I guess this is because the sections before do not exist here (haven't looking into the processing of the tutorial yet. But I assume this is fixed when all sections are combined in de/tutorial...

Copy link
Contributor

@randomguy-2650 randomguy-2650 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve left some review comments on this PR.

@trueberryless trueberryless marked this pull request as ready for review October 5, 2025 10:41
@trueberryless
Copy link
Contributor Author

Awesome finds @randomguy-2650 🙌

Could you please take a look at https://github.com/withastro/docs/pull/12500/files#r2404391432?
We introduced the   there to avoid that "z. B." is separated to two lines, but it seems that you found a better symbol, can you maybe create a suggestion featuring this symbol please, would be awesome 🙌

@randomguy-2650
Copy link
Contributor

Awesome finds @randomguy-2650 🙌

Could you please take a look at https://github.com/withastro/docs/pull/12500/files#r2404391432?

We introduced the   there to avoid that "z. B." is separated to two lines, but it seems that you found a better symbol, can you maybe create a suggestion featuring this symbol please, would be awesome 🙌

That symbol I used is just the Unicode character for the non-breaking space instead of the HTML   syntax.

Copy link
Contributor

@randomguy-2650 randomguy-2650 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve left extra review comments I’ve forgot before.

The reason I know all of these random orthographic rules is due to this absurdly strict style guide I’ve created.

English: https://github.com/placer-toolkit/placer-style-guide/blob/2.x/README.md
Deutsch: https://github.com/placer-toolkit/placer-style-guide/blob/2.x/translations/de/README.de.md


.tag {
margin: 0.25em;
border: dotted 1px #a1a1a1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
border: dotted 1px #a1a1a1;
border: 1px solid #A1A1A1;

Same here.


.tag {
margin: 0.25em;
border: dotted 1px #a1a1a1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
border: dotted 1px #a1a1a1;
border: 1px dotted #A1A1A1;

See above‐above (if that makes sense).


.tag {
margin: 0.25em;
border: dotted 1px #a1a1a1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
border: dotted 1px #a1a1a1;
border: 1px dotted #A1A1A1;

See above.

@trueberryless
Copy link
Contributor Author

Thanks for the awesome review again @randomguy-2650 🙌
All suggestions make sense, I would like to wait with the CSS adjustments to be fixed upstream (English), so it is not just different (better) in the translation, but in all languages eventually 👍

@louisescher louisescher mentioned this pull request Oct 5, 2025
Copy link
Contributor

@randomguy-2650 randomguy-2650 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everyone basically chose “Startseite” in the Discord poll, so I’d update it here.

And I wouldn’t think any other option would get more votes anyways, so I’ll close that poll now.

@trueberryless trueberryless changed the title de(i18n): translate page 1: section 5 of 6 de(i18n): translate tutorial section 5 Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants