[WIP] Added initial support for processing custom components in templates #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We will very probably need support for rendering our own custom Vue components in our server-side rendering. Add an initial sketch of what that might look like. Bug: T395802
codders
force-pushed
the
feat/component-support-20250606
branch
from
ca7c9ae to
5a29835
Compare
| @@ -46,9 +53,24 @@ public function parseHtml( string $html ): DOMDocument { | |||
| //TODO Throw an exception | |||
| } | |||
|
|
|||
| $this->substituteComponents( $document ); | |||
There was a problem hiding this comment.
I think doing component substitution in HtmlParser will run into issues once we want to pass props into them… I was imagining it would take place in Component::handleNode(), probably just before the iteration over the child nodes. (And it should probably throw an “unsupported” exception if there are child nodes, at least until we get around to supporting slots…)
There was a problem hiding this comment.
Yeah - that makes sense. I'm not attached to this approach - this was just a sketch to see what would be possible / how complicated support might turn out to be.
|
Gonna close this as superseded by #35 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will very probably need support for rendering our own custom Vue components in our server-side rendering. Add an initial sketch of what that might look like.
Bug: T395802