Handle complex expressions in for loops and member expressions #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to render structured data in Vue templates, we need to be
able to destructure more complex Javascript expressions both in the
target of 'v-for' statments and in Javascript Member Expressions
that use 'Computed' values.
Here we add support for data structures that use hypens in key names
`<div v-for="item in list['data-values']">`, or numeric key names
`<div v-for="item in list[1]">`, or in the case where the lookup
key is itself an identifier `{{ data[variable] }}``.
Bug: T396098
codders
force-pushed
the
feat/complex-expressions-in-for-loops-20250714
branch
from
3cc9725 to
f08ad1b
Compare
lucaswerkmeister
approved these changes
Jul 14, 2025
lucaswerkmeister
deleted the
feat/complex-expressions-in-for-loops-20250714
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to render structured data in Vue templates, we need to be able to destructure more complex Javascript expressions both in the target of 'v-for' statments and in Javascript Member Expressions that use 'Computed' values.
Here we add support for data structures that use hypens in key names
<div v-for="item in list['data-values']">, or numeric key names<div v-for="item in list[1]">, or in the case where the lookup key is itself an identifier `{{ data[variable] }}``.Bug: T396098